Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/238 delete confirmation message #247

Merged
merged 6 commits into from
Apr 27, 2024
Merged

Fix/238 delete confirmation message #247

merged 6 commits into from
Apr 27, 2024

Conversation

fracalrod3
Copy link
Contributor

  1. Log in with administrator credentials.
  2. Look up Volunteer or Family Requests, or Suggestions.
  3. Click on the "Rechazar" or the trash icon button.
  4. There's the pop-up!

@fracalrod3 fracalrod3 linked an issue Apr 27, 2024 that may be closed by this pull request
Fix/238- Delete confirmation message #238
Closed
claugp06
claugp06 requested changes Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In suggestions the toast message confirmation has been delete it, is not shown and also it stays with the tab of deleting opened.

@claugp06 claugp06 added the bug Something isn't working label Apr 27, 2024
@claugp06 claugp06 added this to the PPL milestone Apr 27, 2024
@fracalrod3
Copy link
Contributor Author

In suggestions the toast message confirmation has been delete it, is not shown and also it stays with the tab of deleting opened.

Sorry, seems I forgot to tell the system to shut the popo-up down, just fixed it, thanks for warning me!

@fracalrod3 fracalrod3 requested review from claugp06 and Ahydul and removed request for manbarjim2 April 27, 2024 14:54
claugp06
claugp06 approved these changes Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@claugp06 claugp06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, now every delete action has a confirmation message!

manbarjim2
manbarjim2 approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@manbarjim2 manbarjim2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is working successfully.

FranciscoRossoR
FranciscoRossoR approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@FranciscoRossoR FranciscoRossoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just something to point out, I personally would change "¿Estás seguro que quieres rechazar?" to something like "¿Está seguro de que quiere rechazar?", but still looks and woks as intended, so well done.

@claugp06 claugp06 removed the request for review from Ahydul April 27, 2024 17:06
@claugp06 claugp06 merged commit 94055de into develop Apr 27, 2024
1 check passed
@claugp06 claugp06 deleted the fix/238-delete-confirmation-message branch April 27, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranciscoRossoR FranciscoRossoR FranciscoRossoR approved these changes

@claugp06 claugp06 claugp06 approved these changes

@manbarjim2 manbarjim2 manbarjim2 approved these changes

Assignees

@fracalrod3 fracalrod3

Labels
bug Something isn't working
Projects
None yet
Milestone
PPL
Development

Successfully merging this pull request may close these issues.

Fix/238- Delete confirmation message
4 participants
@fracalrod3 @manbarjim2 @claugp06 @FranciscoRossoR