Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design flaw in ENV process #463

Closed
Tracked by #177
YuryHrytsuk opened this issue Nov 27, 2023 · 5 comments
Closed
Tracked by #177

Design flaw in ENV process #463

YuryHrytsuk opened this issue Nov 27, 2023 · 5 comments
Assignees
Labels
p:high-prio t:bug Something isn't working

Comments

@YuryHrytsuk
Copy link
Collaborator

YuryHrytsuk commented Nov 27, 2023

Since OPS uses the latest version of the repo.config in osparc.io when it is deployed, we just cannot push a PR in simcore and modify all the repo.config files. Reason for this is what I failed to properly ask in our last meetings, how is it possible to change the repo.config of AWS-production when it will only be released in 2 months? conclusion is that we can change the repo.config of master right away (as it will obviously also be broken quite instantly after the PR is deployed), but the other repo.config files that is another story... No problem with new variables, but big CAUTION with modifications/deletion (C) @sanderegg

@sanderegg @mrnicegyu11 @GitHK @pcrespov

@YuryHrytsuk YuryHrytsuk added t:bug Something isn't working p:high-prio labels Nov 27, 2023
@YuryHrytsuk
Copy link
Collaborator Author

First issue encountered during v1.63.0 release
ITISFoundation/osparc-simcore#5027 (comment)

@YuryHrytsuk YuryHrytsuk changed the title Design flaw in ENV process. Design flaw in ENV process Nov 27, 2023
@pcrespov
Copy link
Member

@YuryHrytsuk As you mention at the end of the description, the only problem would arise with modification or deletion of env-vars.

As a first step I would propose:

  • protect config branch and only allow PRs with reviews
  • Add a PR template with checks that warns about this
  • modifications or deletions can be added as comments with a reference to release issue/name (not super happy about thisone since it would require an extra PR upon release)

@YuryHrytsuk YuryHrytsuk self-assigned this Jan 15, 2024
@YuryHrytsuk YuryHrytsuk added this to the This is Sparta! milestone Jan 15, 2024
@YuryHrytsuk
Copy link
Collaborator Author

The approach is to branch off (created by Matus)

@YuryHrytsuk
Copy link
Collaborator Author

@YuryHrytsuk
Copy link
Collaborator Author

with the help of @matusdrobuliak66 and @sanderegg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:high-prio t:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants