From f4a599c98213c97ec498fadc8be596a9a0209ab9 Mon Sep 17 00:00:00 2001 From: sanderegg <35365065+sanderegg@users.noreply.github.com> Date: Tue, 21 Nov 2023 18:18:43 +0100 Subject: [PATCH] ruff --- services/dask-sidecar/tests/unit/test_file_utils.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/services/dask-sidecar/tests/unit/test_file_utils.py b/services/dask-sidecar/tests/unit/test_file_utils.py index 6f16e9627796..2ca640089627 100644 --- a/services/dask-sidecar/tests/unit/test_file_utils.py +++ b/services/dask-sidecar/tests/unit/test_file_utils.py @@ -5,16 +5,16 @@ import asyncio import mimetypes import zipfile +from collections.abc import AsyncIterable from dataclasses import dataclass from pathlib import Path -from typing import Any, AsyncIterable, cast +from typing import Any, cast from unittest import mock import fsspec import pytest from faker import Faker from pydantic import AnyUrl, parse_obj_as -from pytest import FixtureRequest from pytest_localftpserver.servers import ProcessFTPServer from pytest_mock.plugin import MockerFixture from settings_library.s3 import S3Settings @@ -79,7 +79,7 @@ class StorageParameters: @pytest.fixture(params=["ftp", "s3"]) def remote_parameters( - request: FixtureRequest, + request: pytest.FixtureRequest, ftp_remote_file_url: AnyUrl, s3_remote_file_url: AnyUrl, s3_settings: S3Settings, @@ -314,9 +314,8 @@ async def test_pull_compressed_zip_file_from_remote( mode="wb", **storage_kwargs, ), - ) as dest_fp: - with local_zip_file_path.open("rb") as src_fp: - dest_fp.write(src_fp.read()) + ) as dest_fp, local_zip_file_path.open("rb") as src_fp: + dest_fp.write(src_fp.read()) # now we want to download that file so it becomes the source src_url = destination_url