Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: ✅ testing metrics endpoint #2417

Closed
wants to merge 1 commit into from
Closed

WIP: ✅ testing metrics endpoint #2417

wants to merge 1 commit into from

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 6, 2021 •
edited
Loading

What do these changes do?

Trying to reproduce metrics accumulation issue using locust.io

Related issue/s

How to test

Checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Jul 6, 2021
@sanderegg sanderegg added this to the Marmoset milestone Jul 6, 2021
@sanderegg sanderegg self-assigned this Jul 6, 2021
@codecov
Copy link

codecov bot commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #2417 (4d875f4) into master (d6ea9ea) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2417     +/-   ##
========================================
- Coverage    75.5%   75.4%   -0.1%     
========================================
  Files         560     560             
  Lines       20832   20832             
  Branches     2015    2015             
========================================
- Hits        15737   15727     -10     
- Misses       4565    4572      +7     
- Partials      530     533      +3
Flag Coverage Δ
integrationtests 66.1% <ø> (-0.1%) ⬇️
unittests 69.2% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...webserver/computation_comp_tasks_listening_task.py 83.6% <0.0%> (-6.2%) ⬇️
...erver/src/simcore_service_webserver/director_v2.py 78.0% <0.0%> (-0.8%) ⬇️
.../director/src/simcore_service_director/producer.py 60.9% <0.0%> (-0.7%) ⬇️

@sanderegg sanderegg requested review from GitHK and pcrespov July 6, 2021 07:42
GitHK
GitHK approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, will you be using this in CI to trigger they issue on various deployments?

@sanderegg sanderegg changed the title WIP: testing metrics endpoint WIP: ✅ testing metrics endpoint Jul 7, 2021
@pcrespov pcrespov removed their request for review July 12, 2021 07:26
@sanderegg sanderegg mentioned this pull request Aug 4, 2021
Closed
2 tasks
@sanderegg
Copy link
Member Author

staled.

@sanderegg sanderegg closed this Aug 26, 2021
@sanderegg sanderegg deleted the bugfix/test_metrics_entrypoint branch August 26, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov will be requested when the pull request is marked ready for review pcrespov is a code owner

Assignees

@sanderegg sanderegg

Labels
a:webserver issue related to the webserver service
Projects
None yet
Milestone
Marmoset
Development

Successfully merging this pull request may close these issues.
2 participants
@sanderegg @GitHK