-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 aborting tasks fails #2449
🐛 aborting tasks fails #2449
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2449 +/- ##
========================================
- Coverage 76.0% 75.9% -0.1%
========================================
Files 574 574
Lines 21658 21667 +9
Branches 2078 2082 +4
========================================
- Hits 16465 16464 -1
- Misses 4639 4648 +9
- Partials 554 555 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1a196f8
to
2b1fd4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, just some proposals to be verified.
2b1fd4a
to
f979547
Compare
What do these changes do?
Cancelling tasks seems to have been failing since a couple of PRs went in.
First, the python 3.8 PR changed how asyncio.loop.call_soon is to used.
Then, when the redis database was splitted in 3 separate DBs (one redis instance with 3 databases) instead of 1. the director-v2 celery client was not fixed accordingly.
This has lead to the following:
Both of these issues are now fixed.
Related issue/s
How to test
then start a pipeline with 1sleeper that lasts more than 2 seconds... cancel it. it should instantly be cancelled.
Checklist