Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Maintenance/fix docker buildx in CI #2457

Merged

Conversation

sanderegg
Copy link
Member

What do these changes do?

Docker buildx v0.6.0 seems to have broken the docker bake application. the baked cookies are not getting the environment variables expanded as they used to in the version before.
Until this is clarified see issue the version of docker buildx will be set to 0.5.1.
Coming from the PR #2360, the github action to setup docker buildx with a specific version will be used.

bonus:

  • dependabot on github actions added
  • use github matrix to set versions on docker-compose and docker buildx

Related issue/s

How to test

Checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Jul 30, 2021
@sanderegg sanderegg self-assigned this Jul 30, 2021
@sanderegg sanderegg added this to the Wombat milestone Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #2457 (56e5cb9) into master (73774dc) will increase coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 56e5cb9 differs from pull request most recent head 7efd59f. Consider uploading reports for the commit 7efd59f to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2457   +/-   ##
======================================
  Coverage    70.0%   70.0%           
======================================
  Files         574     574           
  Lines       21654   21654           
  Branches     2082    2082           
======================================
+ Hits        15162   15164    +2     
+ Misses       6020    6019    -1     
+ Partials      472     471    -1     
Flag Coverage Δ
unittests 69.9% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 61.2% <0.0%> (-0.3%) ⬇️
...ages/service-library/src/servicelib/aiopg_utils.py 90.8% <0.0%> (+3.0%) ⬆️

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great

@sanderegg sanderegg merged commit 8393d3b into ITISFoundation:master Jul 30, 2021
@sanderegg sanderegg deleted the maintenance/fix_docker_buildx branch July 30, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants