Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ remove code once #4202 hits production #4204

Closed
GitHK opened this issue May 8, 2023 · 4 comments · Fixed by #4478
Closed

♻️ remove code once #4202 hits production #4204

GitHK opened this issue May 8, 2023 · 4 comments · Fixed by #4478
Assignees
@GitHK
Labels
t:maintenance Some planned maintenance work
Milestone
Watermelon

Comments

@GitHK
Copy link
Contributor

GitHK commented May 8, 2023

once #4202 reaches production remove code

  • _can_save_is_no_longer_none from services/director-v2/src/simcore_service_director_v2/models/schemas/dynamic_services/scheduler.py
@pcrespov
Copy link
Member

pcrespov commented Jun 7, 2023 •
edited
Loading

@GitHK

  • Reminder. I have seen this issue in a warning (good strategy!)
image - #4202 already reached production in https://github.com//issues/4236 . - You might want to take action? :-)

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jun 7, 2023
@pcrespov pcrespov added this to the Watermelon milestone Jun 7, 2023
@GitHK
Copy link
Contributor Author

GitHK commented Jun 7, 2023

Thanks for this. I will put it my list of things to do.

@pcrespov
Copy link
Member

@GitHK closed??

@sanderegg
Copy link
Member

@GitHK @pcrespov
no the warning is still there
What needs to be done?

@GitHK GitHK mentioned this issue Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GitHK GitHK

Labels
t:maintenance Some planned maintenance work
Projects
None yet
Milestone
Watermelon
Development

Successfully merging a pull request may close this issue.

♻️ removing code that is no longer required GitHK/osparc-simcore-forked
3 participants
@GitHK @pcrespov @sanderegg