Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set eager=true in exponentiate backend #40

Open
mtfishman opened this issue Oct 18, 2024 · 0 comments
Open

Set eager=true in exponentiate backend #40

mtfishman opened this issue Oct 18, 2024 · 0 comments

Comments

@mtfishman
Copy link
Member

mtfishman commented Oct 18, 2024 •
edited
Loading

In ITensorTDVP.jl v0.3, we set eager=true by default when using the KrylovKit.exponentiate solver/updater, while in ITensorTDVP.jl v0.4 we don't override the default that KrylovKit.jl sets, which is eager=false. This can potentially have big performance penalties since it can lead to many unnecessary applications of the reduced operator.

See:

For users hitting this issue who are using ITensorTDVP.jl v0.4, you can manually pass updater_kwargs=(; eager=true) to tdvp to get the same (more efficient) behavior of ITensorTDVP.jl v0.3.
@corbett5 corbett5 mentioned this issue Oct 21, 2024
Closed
7 tasks
@mtfishman mtfishman transferred this issue from ITensor/ITensorTDVP.jl Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtfishman