Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove versions taking various argument orderings? #35

Closed
emstoudenmire opened this issue Oct 4, 2022 · 2 comments · Fixed by #74
Closed

Remove versions taking various argument orderings? #35

emstoudenmire opened this issue Oct 4, 2022 · 2 comments · Fixed by #74

Comments

@emstoudenmire
Copy link
Collaborator

Currently there are some interfaces like the tdvp function which have wrappers that allow passing the arguments in a different order, for example:

tdvp(H,psi,t, ...)

instead of

tdvp(H,t,psi,...)

Before finalizing this package, I would suggest we decide on a standard ordering for interfaces like this and remove the other orderings.

@mtfishman
Copy link
Member

One reason I like the second one is that it is more similar to the equation exp(Ht)|psi> (in fact we could consider calling tdvp something like exp or exponentiate, in a future where there are multiple MPO-based time evolution backends).

@emstoudenmire
Copy link
Collaborator Author

Agreed that the second interface is nicer. I think we should just have one of them (since this package hasn't been released yet) so I'm happy with that one being the interface.

@mtfishman mtfishman mentioned this issue May 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants