[ITensorMPS] Added option for MPO-MPS zipup #1536
Conversation
corbett5
changed the title
|
Looks good, thanks @corbett5. Could you add a test for the new functionality? Also could you add something about |
|
@mtfishman I updated the docs and tests, but I seem to be having trouble with the formatting. For one the formatter updated 100+ files which I did not touch, but I also can't get the format check to pass. It passes for me locally with the same JuliaFormatter version (v2.0.0). Also now none of the other tests pass after the extensive format changes. |
|
@corbett5 it looks like JuliaFormatter.jl v2 either accidentally or deliberately changed certain formatting rules, including introducing some bugs into the code by erroneously changing positional arguments to keyword arguments. Please format the code using JuliaFormatter.jl v1 (i.e. revert to the previous formatting), and I can change the formatting CI checks to use JuliaFormatter.jl v1 for now while those issues get worked out. |
corbett5
force-pushed
the
feature/corbett/mpo-mps-zipup
branch
from
3877c20 to
e2979a1
Compare
|
All passing 🎉 Thanks for fixing the formatting problems. |
|
I actually didn't do anything, it looks like the JuliaFormatter.jl v2 release was reverted ("yanked" in the Julia registry parlance) because there were too many bugs (domluna/JuliaFormatter.jl#878). |
mtfishman
changed the title
src/lib/ITensorMPS/src/mpo.jl
Outdated
| - `alg="zipup"`: the algorithm to use for the contraction. Supported algorithms are | ||
| - "naive": The MPO tensors are contracted exactly at each site and then a truncation | ||
| of the resulting MPO is performed. | ||
| - "zipup": The MPO and MPS tensors are contracted then truncated at each site without enforcing | ||
| the appropriate orthogonal gauge. Once this sweep is complete a call to `truncate!` occurs. | ||
| Because the initial truncation is not locally optimal it is recommended to use a loose | ||
| `cutoff` and `maxdim` and then pass the desired truncation parameters to the locally optimal | ||
| `truncate!` sweep via the additional keyword argument `truncate_kwargs`. | ||
| Suggested use is `contract(A, ψ; method="zipup", cutoff=cutoff / 10, maxdim=2 * maxdim, truncate_kwargs=(; cutoff, maxdim))`. |
There was a problem hiding this comment.
It's unfortunate that we are repeating the same docstring in two places.
Can we factorize out the parts that are common to contract and apply in a new string contract_or_apply_mpo_mpo_doc that is used by both of them?
There was a problem hiding this comment.
I just pulled out the zipup docs, but I could do more to bring them in line if you want.
|
@corbett5 could you move this PR over to: https://github.com/ITensor/ITensorMPS.jl? |
|
I'll close this since it needs to be moved to the ITensorMPS.jl repository. |
Description
Minimal changes necessary to extend the "zipup" algorithm for MPO-MPO products to MPO-MPS products. The main request I foresee is to bring it inline with the "naive" algorithm which also has a single implementation for MPO-MPO(S) products. Once those details are worked out I'll add docs and tests.
How Has This Been Tested?
It has not.
Checklist:
using JuliaFormatter; format(".")in the base directory of the repository (~/.julia/dev/ITensors) to format your code according to our style guidelines.