Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets the
log_in_as
specs passing, which started consistently failing after measures were put in place to ensure proper creation of default admin set/permission templates. It was failing while waiting for a lock on theUser
table:I wasn't able to determine what was really holding the database lock, but I was able to get past it by increasing the INNODB lock timeout (default is 50 seconds) in the test database configuration. This has resulted in at least a 50 second wait in the suite, which you can see at work in the test analysis. It points at the "login as" specs as being the second slowest example, when in actuality it's really just waiting for the lock on the User table to be released:
Without this fix, the example run above would have failed on the "Switch User" test because it was 4 seconds over the default lock timeout. This also sends the
clean
directive on the test examples, which didn't help anything, but is consistent with other specs in the suite.