-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: group type-imports when sorting Identifiers #25
Comments
I vote the default value should be |
I forgot to propose the option of "group all the |
How that it's possible to combine type and value imports ( So, with that said, I think that main request in this issue is done now, right? Can we close it, or is there still more to do? |
I think you've made the necessary decision, right? |
Let's run with this for now, and if we hear an outcry from users we can find a way to adjust in the future. Thanks! |
Is your feature request related to a problem?
In #20 we're offering an option to migrate
import type {
expressions into value-imports when needed `import {typeIn #22 we're discussing deleting that configuration-flag, and instead having an opinionated default.
We realized that we probably want to have some configuration for deciding which mode we want.
Example:
Desired Flavors:
importOrderMergeDuplicateImports
#19 (without Feature:importOrderCombineTypeAndValueImports
#20) would produceimportOrderMergeDuplicateImports
#19 with Feature:importOrderCombineTypeAndValueImports
#20 would produceDescribe the solution you'd like
importOrderMergeTypeImports: "disable"
importOrderMergeTypeImports: "separate"
importOrderMergeTypeImports: "mixed"
importOrderMergeTypeImports: "mixed-first"
importOrderMergeTypeImports: "mixed-last"
Describe alternatives you've considered
"mixed"
maybe mixed should actually just refer to one of the options, and not offer the others.Open concerns
importOrderMergeImports
instead?"separate"
aggressively unmerge anytype
imports in a value expression into 2 import statementsimport type + import {}
expressions?The text was updated successfully, but these errors were encountered: