Remove ambiguity between ConfigObject::GetZone() and Endpoint::GetZone()

[julianbrost]

Currently, there exist both ConfigObject::GetZone() and Endpoint::GetZone(). As Endpoint inherits from ConfigObject, it is shadowed but both are non-virtual and behave differently:

• ConfigObject::GetZone() returns the zone that the object is configured within and is relevant for the config sync.
• Endpoint::GetZone() returns the zone that endpoint is a member of (as configured in the endoints attribute of a zone) which is relevant for cluster routing.

This leads to confusing code where GetZone() of the same object behaves differently depending on its static type:

icinga2/lib/icingadb/icingadb-objects.cpp

Lines 1094 to 1098 in 7f5225e

	if (type == Endpoint::TypeInstance) {
	ObjectsZone = static_cast<Endpoint*>(object.get())->GetZone();
	} else {
	ObjectsZone = static_pointer_cast<Zone>(object->GetZone());
	}

Also, when discussing it internally, it was quite hard to refer to both of these zone relationships so we should come up with better and more distinctive naming.

[Ishvina]

Hi! I am in an intro to swe class that is requiring me to work on my first open-source project. I was wondering if this issue is still open and if so could is this beginner-friendly?

[julianbrost]

Hi, thanks for your interest in contributing. This issue is still open and the resulting fix won't need any major code changes, however, the issue requires a good understanding of Icinga 2 and especially its cluster functionality to come up with a meaningful new suggestion for naming things.

[Al2Klimov]

What about GetEndpointZone() for referring to the zone of specifically the endpoint?