Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our license isn't compatible with our deps' ones #381

Closed
Al2Klimov opened this issue Sep 29, 2021 · 1 comment · Fixed by #388
Closed

Our license isn't compatible with our deps' ones #381

Al2Klimov opened this issue Sep 29, 2021 · 1 comment · Fixed by #388
Assignees
Milestone

Comments

@Al2Klimov
Copy link
Member

Describe the bug

As https://github.com/Icinga/icingadb/pull/379/checks?check_run_id=3745669016 reports, right now we're violating our own license by combining the GPLv2 app with a partially Apache2.0 lib.

To Reproduce

Run go mod vendor and read all the licenses in vendor/ (or just trust the linked check).

Expected behavior

Either

Explicitly upgrade our README.md and license headers (which license headers? ba dumm tss) GPLv2 -> GPLv2+. (Luckily as #380 (comment) reports all contributors have signed a CLA which allows sublicensing.)

Or

Get rid of some deps (at least gopkg.in/yaml.v3).

CC @N-o-X @julianbrost

@Al2Klimov
Copy link
Member Author

PS: IMAO GPLv2+ == GPLv3- makes GPLv2+ + Apache2.0 working, but IANAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants