Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role member suggestion endpoint is reachable for unauthorized users #4961

Closed
nilmerg opened this issue Dec 7, 2022 · 0 comments · Fixed by #4954
Closed

Role member suggestion endpoint is reachable for unauthorized users #4961

nilmerg opened this issue Dec 7, 2022 · 0 comments · Fixed by #4954
Assignees
Labels
area/configuration Affects the configuration bug Something isn't working
Milestone

Comments

@nilmerg
Copy link
Member

nilmerg commented Dec 7, 2022

Describe the bug

Any logged in user can, with a specifically crafted request, retrieve role member suggestions. (User- and Usergroup-Names)

To Reproduce

  • Generic user X logs in to Icinga2.
    • Captures icingaweb2 login cookies/session cookies
  • Retrieves suggestion using the request below
curl -L -X POST <IP>/icingaweb2/role/suggest-role-member?_disableLayout=1&showCompact=1' \
-H 'Origin: <IP>' \
-H 'Accept: */*' \
-H 'Content-Type: application/json' \
-H 'Cookie: Icingaweb2=<TOKEN>; icingaweb2-session=<session_EPOCH> \
--data-raw '{"term":{"label":"*"}}'

Expected behavior

Only users with the correct permission should be able to do this.

Additional context

https://rt.icinga.com/Ticket/Display.html?id=43448

@nilmerg nilmerg self-assigned this Dec 7, 2022
@nilmerg nilmerg added bug Something isn't working area/configuration Affects the configuration labels Dec 7, 2022
@nilmerg nilmerg added this to the 2.11.3 milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration Affects the configuration bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant