Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DiscoveryResponse info to SPs in discojson #262

Merged
merged 1 commit into from
May 27, 2024

Conversation

enriquepablo
Copy link
Contributor

@enriquepablo enriquepablo commented Mar 22, 2024

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

This adds a discovery_responses key in the JSON produced by discojson for the SP entities that have DiscoveryResponse elements in their metadata.

This is to allow SeamlessAccess to warn users when they are sent to SeamlessAccess with a return URL that does not match the DiscoveryResponse elements published in the SP metadata.

@mikaelfrykholm
Copy link
Contributor

@c00kiemon5ter I am taking a look at this. Setting up env. now.

Copy link
Contributor

@mikaelfrykholm mikaelfrykholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am working on a test case as well. But this can be merged.

@leifj leifj merged commit 153d879 into IdentityPython:master May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants