Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.otf build has some characters with missing holes #110

Closed
IdreesInc opened this issue Feb 12, 2023 · 1 comment · Fixed by #112
Closed

.otf build has some characters with missing holes #110

IdreesInc opened this issue Feb 12, 2023 · 1 comment · Fixed by #112
Labels
bug Something isn't working

Comments

@IdreesInc
Copy link
Owner

Describe the bug
The .otf build shows characters like 8, o, and O with filled in holes. This does not show up in the .ttf build for some reason.

Screenshots
Screen Shot 2023-02-12 at 4 19 56 PM

Operating system
MacOS

@IdreesInc IdreesInc added the bug Something isn't working label Feb 12, 2023
@Dheatly23
Copy link
Contributor

Dheatly23 commented Feb 13, 2023

Oddly enough, this is not on windows though.

image

I think it's because of differences in how the renderer treats holes. I suspect if the winding of holes is reversed it would solve it. Another solution is to merge polygons whenever possible. The latter is still being developed in my fork.

PS: Just tested reversing windings, it does not affect .otf, but it broke .ttf. Maybe try it just to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants