Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Edit Form #744

Merged
merged 10 commits into from
Dec 20, 2023
Merged

Create Edit Form #744

merged 10 commits into from
Dec 20, 2023

Conversation

negreirosleo
Copy link
Contributor

Description

Add a form to the task listing that allows the user to edit the Task on the spot.

Screenshots

Screencast.from.2023-12-12.11-31-23.webm

@negreirosleo negreirosleo marked this pull request as draft December 12, 2023 14:33
@negreirosleo negreirosleo force-pushed the create-edit-form branch 2 times, most recently from c3f33ea to bd0d610 Compare December 13, 2023 15:28
dmtrek14
dmtrek14 reviewed Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@dmtrek14 dmtrek14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Ana, I had a few structural questions here that might simply be my own lack of knowledge about Next.js project architecture.

Functionally, the edit form works well so far and I like it better than the original modal concept.

frontend/src/app/tasks/components/TaskBox.tsx Show resolved Hide resolved
frontend/src/app/tasks/page.tsx Show resolved Hide resolved
@negreirosleo negreirosleo marked this pull request as ready for review December 14, 2023 20:02
@negreirosleo
Set sx as optional prop on TextArea
3352d6b
@negreirosleo
Rename Task component to TaskBox
6a25f46 
Also moved the useDeletTask hook call to insided of component and added
edit icon to set task edition
@negreirosleo
Add projects and taskTypes to TaskList
aed61f4 
This data is used for the task edition, so it needs to be accessed by
the TaskBox component
@negreirosleo
Improve schema validation for Task type
f39fa87
@negreirosleo
Make getOverlappingTasks function more flexible
f3f714e 
It can be used by both Tasks and TasksIntents, making it usable on
creation or edition
@negreirosleo
Create editTask api call
bb5c135 
This creates the api function and the hook to use in the components
@negreirosleo
Create EditTask component
e694d37
@negreirosleo
Add AlertProvider to test renderer
755ef9a
@negreirosleo
Create EditTask test
6f14d8b
dmtrek14
dmtrek14 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@dmtrek14 dmtrek14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for also working on the restructuring for DayView/TaskForm so that the code is more clear.

@anarute
Copy link
Member

anarute commented Dec 18, 2023

Switching projects is not working very well (I'm using Chromium):

Screencast.from.2023-12-18.16-43-42.webm

@anarute
Copy link
Member

anarute commented Dec 20, 2023

Switching projects is not working very well (I'm using Chromium):

Screencast.from.2023-12-18.16-43-42.webm

This is working now

anarute
anarute approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@anarute anarute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@negreirosleo negreirosleo merged commit d266c1b into main Dec 20, 2023
2 checks passed
@negreirosleo negreirosleo deleted the create-edit-form branch December 20, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmtrek14 dmtrek14 dmtrek14 approved these changes

@anarute anarute anarute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@negreirosleo @anarute @dmtrek14