Add dates to holiday summary report header #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrek14
force-pushed
the
holiday-summary
branch
from
9e647a9
to
59caf3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some additional information to the table header in the holiday summary report - specifically, it adds the first day of the week. This change is made so that users won't have to look up when an ISO week starts and can then have a better idea of when leaves are happening.
Once again, some of the changes show here are from auto-formatting - sorry!
Main change in HolidayService.php is in lines 420-426 where the new array is created that has the week ('2024W01') and the weekStartDate ('Jan 1').
Main changes in holidaySummary.js are at lines 36 and 105 where the weeksStartDate is added and filled.
Then in the holidaySummary.php, the change is at line 69 where the additional info (the week start date) is added to the table header.