Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wolvic is too bright #1479

Closed
yuripourre opened this issue Jul 14, 2024 · 10 comments
Closed

Wolvic is too bright #1479

yuripourre opened this issue Jul 14, 2024 · 10 comments
Labels
needinfo Further information is requested

Comments

@yuripourre
Copy link

yuripourre commented Jul 14, 2024

Configuration

Wolvic version: trunk
Wolvic build ID:

Hardware: Oculus Quest 2

Steps to Reproduce

  1. Open Wolvic
  2. Access any page
  3. Confirm the page is too bright

Current Behavior

The web page is too bright, specially comparing to the Oculus Browser

Expected Behavior

Page has regular brightness

Possible Solution

Set default brightness to a lower value

Context

The image below shows Wolvic on top and Oculus browser in the bottom. Wolvic is clearly very bright.

image showing the same page in oculus browser and Wolvic

Error Logs and Stack Traces


@yuripourre yuripourre changed the title App is too bright Wolvic Chromium is too bright Jul 14, 2024
@svillar
Copy link
Member

svillar commented Jul 15, 2024

Hmm I doubt there are differences caused by Chromium there. Have you tried the Gecko version?

@yuripourre
Copy link
Author

Hmm I doubt there are differences caused by Chromium there. Have you tried the Gecko version?

No, I couldn't build gecko-dev. I can try to download the gecko version and compare.

Is there any way to change the brightness via code? I've found some methods but calling them didn't have any noticable effect.

@yuripourre yuripourre changed the title Wolvic Chromium is too bright Wolvic is too bright Jul 15, 2024
@svillar
Copy link
Member

svillar commented Jul 15, 2024

Hmm I doubt there are differences caused by Chromium there. Have you tried the Gecko version?

No, I couldn't build gecko-dev. I can try to download the gecko version and compare.

Is there any way to change the brightness via code? I've found some methods but calling them didn't have any noticable effect.

We haven't used gecko-dev for a while. You don't actually need to build it as long as you don't use WebXR. For a non-WebXR enabled Wolvic you can just use the version from Maven. It should work out of the box

@svillar
Copy link
Member

svillar commented Jul 30, 2024

It is not a problem with chromium. Check the following two screenshots, top is with Chromium bottom with Gecko. Both taken in a Pico4. I'll check later with a Meta device, because I know we have specific code for gamma there and that might be the issue
Screenshot_com igalia wolvic dev_2024 07 30-10 12 53 598_801
Screenshot_com igalia wolvic_2024 07 30-09 51 37 890_343

@svillar svillar added bug Something isn't working needinfo Further information is requested and removed bug Something isn't working labels Jul 30, 2024
@svillar
Copy link
Member

svillar commented Jul 30, 2024

@yuripourre are you sure you didn't change anything in the code? I cannot see any difference in brightness. I'm attaching 3 new pictures, the first two using Wolvic with chromium and gecko and the last one the Meta browser.
54
55
57

@yuripourre
Copy link
Author

@svillar thanks for investigating!

I didn't change anything, I compiled as-is. I will try pull master again e make a new test.

I can also try in another device, just in case. I will let you know.

@svillar
Copy link
Member

svillar commented Aug 12, 2024

@svillar thanks for investigating!

I didn't change anything, I compiled as-is. I will try pull master again e make a new test.

I can also try in another device, just in case. I will let you know.

Have you verified the issue?

@yuripourre
Copy link
Author

@svillar Hi, I didn't verify yet. I am sorry, busy weeks.

I will update here when I test it.

@svillar
Copy link
Member

svillar commented Sep 7, 2024

@yuripourre news?

@yuripourre
Copy link
Author

@svillar I am sorry, I've been focusing in other projects, I will close this issue, if I make time to test it and the problem persists I can reopen.

Thank you so much for taking time to investigate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants