Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgxGrid filter: IgxDatePicker.weekStart not changable #10852

Closed
Timmeeeey opened this issue Jan 18, 2022 · 3 comments
Closed

IgxGrid filter: IgxDatePicker.weekStart not changable #10852

Timmeeeey opened this issue Jan 18, 2022 · 3 comments
Assignees
Labels
🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Timmeeeey
Copy link

Is your feature request related to a problem? Please describe.

Currently it is not possible to set weekStart for grid IgxDatePicker filter.
It is always set to Sunday.

Describe the solution you'd like

A possible solution would be to make weekStart globally configurable.
See #10543

Describe alternatives you've considered

Alternatively the first day of week could be read from current locale.

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Mar 20, 2022
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Mar 21, 2022
@Volen99 Volen99 added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Apr 13, 2022
@Volen99 Volen99 added ✔️ status: approved Status for feature-requests that have been reviewed and approved for implementation. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 21, 2022
@hanastasov hanastasov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed ✔️ status: approved Status for feature-requests that have been reviewed and approved for implementation. labels Jun 1, 2022
@kdinev kdinev closed this as completed Jun 24, 2022
@hanastasov
Copy link
Contributor

Hi @Timmeeeey , with the patch scheduled to be released today for version 14, the requeted feature will be available:

  • ability to set locale and weekStart for IgxDatePicker`, as it has been available for the calendar
  • ability to set weekStart per column for the grid, through the pipeArgs input property
  • if not set, locale will inherit the value of the global application locale
  • if not set, weekStart will be read from current locale

Since to achieve this new props are introduced, change is only introduced in version 14. Is this the version that you are using?

@hanastasov
Copy link
Contributor

hanastasov commented Jul 1, 2022

@Timmeeeey , the feature is going to roll out with version 14.1, not with minor patch of version 14.0. Sorry for misleading you with my information. Is that ok with you? If you expect that in 14.0 and can't wait for 14.1, just let us know so that we release it with 14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

No branches or pull requests

5 participants