Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a set of properties to be settable to default grid CRUD editors without the need for templates #14009

Closed
ChronosSF opened this issue Mar 22, 2024 · 3 comments
Assignees
Labels
grid: cell-editing grid: row-editing 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ChronosSF
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently every customization for the grid's default editors requires fully custom templates which however sometimes add complexity far beyond what the change calls for (e.g. having to handle change events and value assignments for simply wanting to change some display format)

Describe the solution you'd like

The column component can accept some objects based on pre-defined interfaces that it then uses to init its editors with the default templates.

Describe alternatives you've considered

n/a

Additional context

n/a

@ChronosSF ChronosSF changed the title Provide a set of features to be settable to default editors without the need for templates Provide a set of properties to be settable to default grid CRUD editors without the need for templates Mar 22, 2024
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 25, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
@ddaribo ddaribo reopened this Jun 11, 2024
@github-actions github-actions bot removed the status: inactive Used to stale issues and pull requests label Jun 12, 2024
@ddaribo ddaribo added 👀 status: in-review Issue is currently being reviewed and removed 🆕 status: new labels Jun 26, 2024
@ddaribo
Copy link
Contributor

ddaribo commented Jun 26, 2024

In continuation of this comment, the currently identified candidate properties are:

  • inputFormat - could be part of the IFieldPipeArgs interface; alternatively - defined on the column (i.e. editorInputFormat or else); applicable for the date, dateTime and time column types.
  • inputMask - also could be part of the IFieldPipeArgs or else; applicable for string and image column data types as they both use the same template - a text input group. The igxMask cannot be applied for number type inputs, so not applicable for number, currency and percent types.

Let me know what you think @ChronosSF, @rkaraivanov. @kacheshmarova could schedule a meeting to further discuss the specs.

@ddaribo
Copy link
Contributor

ddaribo commented Jul 1, 2024

To sum up the meeting discussion:

  • An editorOptions object would be exposed on the column and for now it would contain a single property - dateTimeFormat (names to be further polished). This will be applied to the default editors of date, time and dateTime columns.
  • In case such an editorOptions.dateTimeFormat config is not provided, we would try to infer the date/time inputFormat from the set pipeArgs.displayFormat, if any. The condition for the displayFormat to be applied as inputFormat is that its date-time parts can be parsed as all numeric. If not, the editor’s inputFormat will fallback as per the grid’s locale (Note: currently it is a hardcoded default format for the dateTime column type).
  • The current feature would not cover properties for numeric column types. They would be subject to future discussions about creating separate numeric inputs.

@ddaribo ddaribo assigned ddaribo and unassigned rkaraivanov Jul 1, 2024
@ddaribo ddaribo added 🛠️ status: in-development Issues and PRs with active development on them and removed 👀 status: in-review Issue is currently being reviewed labels Jul 3, 2024
@ddaribo ddaribo closed this as completed Aug 19, 2024
@ddaribo ddaribo reopened this Aug 19, 2024
@ddaribo ddaribo added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. 🛠️ status: in-development Issues and PRs with active development on them and removed 🛠️ status: in-development Issues and PRs with active development on them ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels Oct 3, 2024
@kacheshmarova kacheshmarova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: cell-editing grid: row-editing 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

No branches or pull requests

4 participants