Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for "Wk" for week numbers in calendars #14423

Closed
PooSham opened this issue Jun 20, 2024 · 0 comments · Fixed by #14443
Closed

Translation for "Wk" for week numbers in calendars #14423

PooSham opened this issue Jun 20, 2024 · 0 comments · Fixed by #14443
Assignees
Labels
📆 calendar 🔣 i18n 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@PooSham
Copy link

PooSham commented Jun 20, 2024

Is your feature request related to a problem? Please describe.

The calendar has the ability to show week numbers. However, the header label for the week numbers is hard coded to "Wk", even when using other locales

Here's the code that includes the hard coded string: https://github.com/IgniteUI/igniteui-angular/blob/master/projects/igniteui-angular/src/lib/calendar/days-view/days-view.component.html

Describe the solution you'd like

I think it should be added to igniteui-angular-i18n/src/i18n/XX/grid-resources.ts and used in the template so that different locales get different week abbreviations.

In Swedish, the common abbreviation for week is v.. In some languages there may not exist any common abbreviation (I think that's the case with French), but I guess you can just pick something (Sm in French maybe?) and have a title-attribute on the element with the whole word (so that it shows by hovering on the element).

Describe alternatives you've considered

Make the text an input to the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📆 calendar 🔣 i18n 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants