Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel Component: Missing Features and Discrepancies between WC #14627

Closed
SisIvanova opened this issue Aug 14, 2024 · 0 comments · Fixed by #14651
Closed

Carousel Component: Missing Features and Discrepancies between WC #14627

SisIvanova opened this issue Aug 14, 2024 · 0 comments · Fixed by #14651
Assignees
@RivaIvanova @radomirchev
Labels
🎠 carousel 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@SisIvanova
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

After implementing the carousel in the Web Components, the Angular component needs some refactoring to completely correspond to the WC one.

Describe the solution you'd like

  1. "Focused" classes have to be dynamically added to the navigation buttons and indicators container once they are focused via keyboard and removed once the user interacts with the mouse. As soon as this is implemented, styles for focused states can be added.

  2. The WC carousel supports vertical mode but this feature is missing in Angular.

  3. The WC carousel has functionality for hiding both the indicators and the navigation buttons whereas in Angular users can hide only the navigation buttons.

*In WC the navigation buttons are implemented using igc-button but in Angular we use div elements styled like buttons. This shouldn't be a problem as long as they look and behave the same.
@ddaribo ddaribo assigned RivaIvanova and unassigned kacheshmarova Aug 20, 2024
@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Aug 20, 2024
@RivaIvanova RivaIvanova mentioned this issue Aug 20, 2024
Merged
14 tasks
@RivaIvanova RivaIvanova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Aug 26, 2024
@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. 🛠️ status: in-development Issues and PRs with active development on them labels Sep 4, 2024
@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. 🛠️ status: in-development Issues and PRs with active development on them labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RivaIvanova RivaIvanova

@radomirchev radomirchev

Labels
🎠 carousel 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(carousel): align with WC carousel IgniteUI/igniteui-angular
4 participants
@kacheshmarova @RivaIvanova @radomirchev @SisIvanova