Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native add row #5946

Closed
Eralmidia opened this issue Oct 9, 2019 · 12 comments · Fixed by #8240
Closed

Native add row #5946

Eralmidia opened this issue Oct 9, 2019 · 12 comments · Fixed by #8240

Comments

@Eralmidia
Copy link

Is your feature request related to a problem? Please describe.

It would be nice to have native support for adding a new row. This can of course be accomplished today with the edit row functionality, but it is a bit cumbersome.

For instance in some cases a grid have read only columns, meaning that row edit for those columns are disabled. But when adding a new row, these columns may still need an input. In other cases, a grid might be fully read only, but still have the ability to add new rows, in which case we need to enable/disable row editing when row adding starts/ends.

Describe the solution you'd like

A distinction between add new row and edit exiting row

@Eralmidia
Copy link
Author

Just to add the discussion from #5947 to this thread: it would be great if the add row used the same transaction based system as editing. Like many others, we use state managements libraries (ngrx, ngxs, akita ect). These systems stream immutable objects, which in turn typically means that the data source for the grid also is immutable, and edits should result in store updates, rather than manipulation of a local array of data.

@Eralmidia
Copy link
Author

@kdinev Any chance of including this in the not to distant future? 🙏

@kdinev
Copy link
Member

kdinev commented Jan 15, 2020

@Eralmidia It's actually a good time to ask this question. We're currently building the roadmap for the next iteration.

@radomirchev Can we consider this for the next milestone, or is the milestone full already?

@Eralmidia
Copy link
Author

@kdinev @radomirchev Did this make it into the milestone?

@radomirchev
Copy link
Contributor

@Eralmidia what we have in the current milestone is Row Pinning #6640 which is prerequisite for a solution for your request. The development has started this sprint. Once is ready we will start working on the sample. You could follow the sprints schedule and progress here.

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 13, 2020
@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label Jun 9, 2020
@radomirchev radomirchev reopened this Jun 9, 2020
@StefanIvanov StefanIvanov self-assigned this Aug 10, 2020
@Eralmidia
Copy link
Author

@radomirchev I see this was moved to validation in the current sprint. Will it be in 10.2?

@StefanIvanov
Copy link
Contributor

Hello @Eralmidia we have a design that we are validating internally, so to be more exact the feature is still in the design/specification phase that we plan to finish very soon

@ChronosSF
Copy link
Member

@Eralmidia , I am happy to inform you that we added the requested functionality with the latest 10.2.0 release. Please, check the documentation for more information - https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid/row_adding.html

@Eralmidia
Copy link
Author

@ChronosSF One question: how do you trigger the add row grammatically? We generally have buttons etc outside the scope of the grid which also needs to be able to start a new add row (for instance from a menu bar in the feature module). I see the addRow method, but this was present before 10.2 as well, so I assume this still just inserts an empty row into the grid?

@ChronosSF
Copy link
Member

ChronosSF commented Oct 21, 2020

There is something wrong with the API docs missing the new stuff for 10.2 that we are looking into.

The idea is for the API to correspond with the design, so spawning the UI happens when you call the beginAddRow method for a given existing IgxGridRowComponent (you can get all of those instances with grid.rowList) . For tree grid rows you also have beginAddChild .

@Eralmidia
Copy link
Author

@ChronosSF Excellent, I'll await the docs fix, and try out the new feature soon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants