Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on pin/unpin when pane's headerId is defined #2

Closed
teodosiah opened this issue Dec 3, 2020 · 1 comment
Closed

Issue on pin/unpin when pane's headerId is defined #2

teodosiah opened this issue Dec 3, 2020 · 1 comment
Assignees
Labels
bug Something isn't working status: resolved

Comments

@teodosiah
Copy link

Description

When headerId of some pinned pane is set to slot like for example the following:

 <div slot="header1" class="header-slot">
    <span >Pane 1</span>
    <div class="additional-buttons">
    <button #btn igxButton="icon" (click)="deleteButton(btn)">
        <igx-icon class="custom-button">delete</igx-icon>
    </button>
    </div>
</div>

and the user unpin the pane it's header is not visible in the area where all unpinned panes are displayed.

Steps to reproduce

  1. Create IgcDockManager with several panes
  2. Set the slot above to the headerId of some of the panes
  3. Unpin this pane

Result

image

Expected result

image

@DiyanDimitrov
Copy link
Contributor

Since a slot can be projected at a single place in the DOM, we have decided to expose different slot properties for each location the header is displayed:

  • headerId - slot rendered in the content pane header
  • tabHeaderId - slot rendered in the tab header
  • unpinnedHeaderId - slot rendered in the unpinned pane header

If any of these slot properties is not set, the value of the header property will be rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: resolved
Projects
None yet
Development

No branches or pull requests

2 participants