Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent theme, Rating uses wrong colors #481

Closed
desig9stein opened this issue Aug 16, 2022 · 5 comments · Fixed by #867
Closed

Fluent theme, Rating uses wrong colors #481

desig9stein opened this issue Aug 16, 2022 · 5 comments · Fixed by #867

Comments

@desig9stein
Copy link
Contributor

Description

There are color differences between our fluent theme and ms fluent

@desig9stein desig9stein added bug Something isn't working 🆕 status: new The issue is new and will be reviewed when somebody picks it up. rating fluent-theme labels Aug 16, 2022
@simeonoff
Copy link
Collaborator

@sdimchevski do you plan on updating the designs in the UI kits to reflect the latest changes in Fluent UI?

@sdimchevski
Copy link

@simeonoff Yep, we've started working on Indigo.Design UI Kit for Fluent in Figma and we plan updating

@simeonoff simeonoff assigned desig9stein and unassigned simeonoff Aug 7, 2023
@desig9stein
Copy link
Contributor Author

desig9stein commented Aug 8, 2023

@sdimchevski I saw that there are still differences, do you plan to align the kit with the fluent design or I can safely implement what we have in the kit now?

@desig9stein desig9stein added 👀 status: in-review and removed 🆕 status: new The issue is new and will be reviewed when somebody picks it up. labels Aug 8, 2023
@sdimchevski
Copy link

sdimchevski commented Aug 8, 2023

@desig9stein I don't see notable differences. Only the shape of the star is a little different, colors are more or less the same. So yes, you can implement what we have in the Fluent UI kit

@sdimchevski
Copy link

@desig9stein I see discrepancies between your implementation and what we have in the kit. Please fix the following colors to comply with those in the Fluent UI kit

Light

Full Star:
enabled: warn-900
disabled: warn-100

Empty Star:
disabled: warn-100

Dark

Full Star:
enabled: gray-800
disabled: warn-900

Empty Star:
enabled: gray-400
disabled: warn-900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants