Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog component - content part section is overwriting max-width value #532

Closed
dobromirts opened this issue Oct 27, 2022 · 0 comments · Fixed by #541
Closed

Dialog component - content part section is overwriting max-width value #532

dobromirts opened this issue Oct 27, 2022 · 0 comments · Fixed by #541
Assignees
Labels
bug Something isn't working ✅ status: resolved

Comments

@dobromirts
Copy link
Contributor

Description

When the dialog has a custom content with width style e.g 480px the correct sizes will not be applied to it and the 'content' section is not displayed correctly, due to
[part='content'] {
max-width: 40ch;
color: $content-color;
...
}
defined in dialog.base.scss.
dialog-content-section

Steps to reproduce

  1. Create dialog component
  2. Use this code as an example
    <igc-dialog ?closeOnOutsideSelect="${true}" ?closeOnEscape="${true}" id="new-task-dialog"> <h3 slot="title"> <h5> Add New Task </h5> </h3> <div class="column-layout group_5"> <igc-input label="Task Title" ?outlined="${false}" class="input"></igc-input> <div class="row-layout group_6"> <igc-select ?outlined="${false}" label="Project" placeholder="Pick a project" class="select"> <span slot="prefix"> <span class="material-icons icon_1"> assignment </span> </span> <igc-select-item value="Option"> Fintech Project </igc-select-item> <igc-select-item value="Option"> DataViz Project </igc-select-item> <igc-select-item value="Option"> Onboarding Project </igc-select-item> <igc-select-item value="Option"> AppBuilder Project </igc-select-item> </igc-select> <igc-select ?outlined="${false}" label="Status" placeholder="Set Status" class="select_1"> <span slot="prefix"> <span class="material-icons icon_1"> schedule </span> </span> <igc-select-item value="Option"> To Do </igc-select-item> <igc-select-item value="Option"> In Development </igc-select-item> <igc-select-item value="Option"> Validation </igc-select-item> <igc-select-item value="Option"> Done </igc-select-item> </igc-select> </div> </div> <div slot="footer"> <igc-button @click=${() => this.newTaskDialog?.toggle()} class="button_1"> Create Task <igc-ripple></igc-ripple> </igc-button> </div> </igc-dialog>

And styles for the content e.g
.group_5 { justify-content: flex-start; align-items: stretch; align-content: flex-start; position: relative; width: 480px; min-width: 50px; min-height: 50px; }
3. Check dialog and section widths

@dobromirts dobromirts added bug Something isn't working 🆕 status: new The issue is new and will be reviewed when somebody picks it up. labels Oct 27, 2022
@simeonoff simeonoff assigned SisIvanova and unassigned simeonoff Oct 31, 2022
@simeonoff simeonoff added 🛠️ status: in-development and removed 🆕 status: new The issue is new and will be reviewed when somebody picks it up. labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ✅ status: resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants