From 35f39219d5c6870f6f8ecdbf47e47f249faa527c Mon Sep 17 00:00:00 2001 From: emanuel-imaginationmedia Date: Wed, 24 Jul 2024 16:08:26 -0300 Subject: [PATCH 1/2] [IMIN-221] Throw errors instead of logging them --- src/index.ts | 66 ++++++++++++++++++++-------------------------------- 1 file changed, 25 insertions(+), 41 deletions(-) diff --git a/src/index.ts b/src/index.ts index 5e35262..6e925c5 100644 --- a/src/index.ts +++ b/src/index.ts @@ -101,24 +101,20 @@ class MagentoApi { * @returns Promise */ async get(path: string, data: any | null = null): Promise { - try { - let url = `${this.getUrl()}${path}` - - if (data) { - let params = { - searchCriteria: data - } - url += `?${this.parseQueryString(params)}` - return await axios.get(url, { - headers: this.getHeaders(url, "GET") as any, - }) - } else { - return await axios.get(`${this.getUrl()}${path}`, { - headers: this.getHeaders(url, "GET") as any - }) + let url = `${this.getUrl()}${path}` + + if (data) { + let params = { + searchCriteria: data } - } catch (error: any) { - console.error(error) + url += `?${this.parseQueryString(params)}` + return await axios.get(url, { + headers: this.getHeaders(url, "GET") as any, + }) + } else { + return await axios.get(`${this.getUrl()}${path}`, { + headers: this.getHeaders(url, "GET") as any + }) } } @@ -129,14 +125,10 @@ class MagentoApi { * @returns Promise */ async post(path: string, data: any): Promise { - try { - const url = `${this.getUrl()}${path}` - return await axios.post(url, data, { - headers: this.getHeaders(url, "POST") as any - }) - } catch (error: any) { - console.error(error) - } + const url = `${this.getUrl()}${path}` + return await axios.post(url, data, { + headers: this.getHeaders(url, "POST") as any + }) } /** @@ -146,14 +138,10 @@ class MagentoApi { * @returns Promise */ async put(path: string, data: any): Promise { - try { - const url = `${this.getUrl()}${path}` - return await axios.put(url, data, { - headers: this.getHeaders(url, "PUT") as any - }) - } catch (error: any) { - console.error(error) - } + const url = `${this.getUrl()}${path}` + return await axios.put(url, data, { + headers: this.getHeaders(url, "PUT") as any + }) } /** @@ -162,14 +150,10 @@ class MagentoApi { * @returns Promise */ async delete(path: string): Promise { - try { - const url = `${this.getUrl()}${path}` - return await axios.delete(url, { - headers: this.getHeaders(url, "DELETE") as any - }) - } catch (error: any) { - console.error(error) - } + const url = `${this.getUrl()}${path}` + return await axios.delete(url, { + headers: this.getHeaders(url, "DELETE") as any + }) } /** From 8df0050d1e70168f6a4d3cfe7f3eb212075863db Mon Sep 17 00:00:00 2001 From: emanuel-imaginationmedia Date: Wed, 24 Jul 2024 16:19:29 -0300 Subject: [PATCH 2/2] [IMIN-221] Update package version --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7312ac2..09eadd1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@imagination-media/magento-api-rest", - "version": "3.0.9", + "version": "3.0.10", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@imagination-media/magento-api-rest", - "version": "3.0.9", + "version": "3.0.10", "license": "SEE LICENSE IN README.MD", "dependencies": { "axios": "^1.6.7", diff --git a/package.json b/package.json index 80412fc..b6bc981 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@imagination-media/magento-api-rest", - "version": "3.0.9", + "version": "3.0.10", "description": "Magento API wrapper", "main": "lib/index.js", "files": [