Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs pulling in IPs #34

Closed
punkrokk opened this issue Oct 16, 2019 · 5 comments
Closed

URLs pulling in IPs #34

punkrokk opened this issue Oct 16, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@punkrokk
Copy link

punkrokk commented Oct 16, 2019

If I have a URL with a port - e.g. 1.1.1.1:449 I'm seeing a URL getting extracted in the format of:
http://1.1.1.1:449.

Is that desired behavior?

@punkrokk
Copy link
Author

bump

@luis261
Copy link

luis261 commented Apr 14, 2021

I have the same problem, even if no port is given, if the IP is defanged.
grafik

@battleoverflow battleoverflow self-assigned this Jan 9, 2023
@battleoverflow battleoverflow added the bug Something isn't working label Jan 9, 2023
@battleoverflow
Copy link
Contributor

Hi, @punkrokk!

This issue is now resolved and available in the develop branch. I will send another comment here once a new version is available for download from PyPI.

Here's an example with the new code:

import iocextract

def extract_no_scheme_urls():
    url = "1[.]1[.]1[.]1:443"
    print(list(iocextract.extract_urls(url, refang=True, no_scheme=True)))

extract_no_scheme_urls()

@battleoverflow
Copy link
Contributor

New version is now available on PyPI: https://pypi.org/project/iocextract/1.14.0/

@luis261
Copy link

luis261 commented Jan 13, 2023

New version is now available on PyPI: https://pypi.org/project/iocextract/1.14.0/

@azazelm3dj3d while it seems like the bug originally referenced in this issue is fixed in the new version, the one I commented above still exists. Defanged IPs still get extracted by extract_urls while their non-defanged counterparts don't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants