Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing isUS key #19

Open
indigo-jay opened this issue Oct 7, 2023 · 0 comments
Open

Missing isUS key #19

indigo-jay opened this issue Oct 7, 2023 · 0 comments
Labels

Comments

@indigo-jay
Copy link

It appears that at some point, isUS was added to the device config. Problem is, when accessing that key in the RFX library, they assume that it exists by referencing that key in the property dict. This fails for older devices that never had that key added. I think the best option would be to assume it's US (so do a .get("isUS", True)) and perhaps log the assumption and prompt the user to update the device. But there are other options as well (i.e. deviceStartComm could be updated to look for the missing key and do something there).

@indigo-jay indigo-jay added the bug label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant