Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: cancelSwapRequest failing on all dexs #53

Closed
ItsDaveB opened this issue Jul 18, 2023 · 6 comments · Fixed by #73
Closed

[Bug]: cancelSwapRequest failing on all dexs #53

ItsDaveB opened this issue Jul 18, 2023 · 6 comments · Fixed by #73
Labels
bug Something isn't working

Comments

@ItsDaveB
Copy link
Collaborator

ItsDaveB commented Jul 18, 2023

Data Provider

Blockfrost

DEX

SundaeSwap

Description

When using the following code to cancel a swap request, that was sitting in Sundaeswap as out of range.
dexter.newCancelSwapRequest().forTransaction(transactionId).forDex(dexName).cancel();

The below error was received, I subscribed to the onSigning and logged out the error below.
I can replicate this each time on Sundae, I haven't tested any other dex as of yet, will update this when I do.

EDIT: this also happens on Minswap each time too.

image

@ItsDaveB ItsDaveB added the bug Something isn't working label Jul 18, 2023
@danielNg25
Copy link

I got the same error on Minswap

@ItsDaveB ItsDaveB changed the title [Bug]: cancelSwapRequest failing. [Bug]: cancelSwapRequest failing on all dexs Jul 19, 2023
@danielNg25
Copy link

@Sluder Hi Is cancel swap request working well?

@Sluder
Copy link
Member

Sluder commented Jul 21, 2023

@ndtr2000 @dpbeaumont I'm taking a look at this today

@ItsDaveB
Copy link
Collaborator Author

We need to use .collectFrom flow here, I've managed to successfully cancel across most dex's. Just needs improving to remove hardcoded scripts.

@danielNg25
Copy link

@dpbeaumont can you share more about how you workaround with that, may be a piece of code?

@danielNg25
Copy link

@dpbeaumont hi, can you help me on the cancel one

@Sluder Sluder linked a pull request Jan 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants