Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question regarding the termination condition. #3

Open
saeyoon17 opened this issue Sep 12, 2024 · 0 comments
Open

Question regarding the termination condition. #3

saeyoon17 opened this issue Sep 12, 2024 · 0 comments

Comments

@saeyoon17
Copy link

saeyoon17 commented Sep 12, 2024 •
edited
Loading

Hi, I have a question regarding the termination condition for each batch.
longspec_benchmark.py terminates a batch if a single instance in the batch reaches desired amount or produces eos token.

But shouldn't the system wait for all other instances to finish?
Or is this a technique used commonly to estimate performance of speculatvie decoding?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saeyoon17