-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase alarm +/- to 5 min #1101
Comments
We could do +5 min and -1 min. To help speed things up? Also +5 secs and -1 secs. |
Maybe, but this increases the worst case to 12 (or 16 with 1-min steps). Also, I fear it may be too unintuitive for a normal user when + and - behave differently. We would at least have to make this very clear in the UI. |
Plenty of room on the buttons to have the text |
Honestly, I am not convinced of asymmetric +/-. I would go either +1/-1 or +5/-5. |
Would it be possible to detect long pressing +/- and to constantly add or decrease the number of minutes? |
There was some discussion regarding number-selection in #1093. Other ideas were to have a long press on the buttons for higher increase/decrease or double tap ability (although that would be a bit hard to implement). |
I like the toggle long press idea. Long press could toggle the buttons into a different mode (with something like red background. Super buttons!) that make +/-5 or maybe even +/-10. Another long press would toggle them back to standard gray +/-1. |
Just a long-term thought: Upgrading to LVGL 8 would allow replacing the +/- buttons with a roller widget: https://docs.lvgl.io/8/widgets/core/roller.html LVGL 7 that InfiniTime is currently using has the roller widget too, but it doesn't support styling. The upgrade from 7 to 8 would not be trivial, but I think it'd pay off: #616 |
That would be the best option 😊 But it seems quite far away right now. |
Press and hold to quickly increase the time is easy to implement, I've got a UI overhaul for the timer/alarm in the works which does exactly this. |
I like your work and will close this issue once your changes are merged, because I guess they resolve my initial problem. |
Ok, I'll publish the PR as soon as I have the stop button fixed, I should be able to link it to this issue so it'll close when merged. |
Verification
Pitch us your idea!
Increase the steps for alarm +/- to 5 min.
Description
I guess this is controversial, so sorry for that 😁
Almost always I am not interesetd in setting a alarm to an odd time (say 10:38), but a lot of the time, I end up tapping the +-button a million times to get to the desired time.
I therefore propose to set the alarm time setting steps to 5 min.
Also, we should then make sure to have an initial time that is divisible by 5, to not end up with something like (3, 8, 13, …).
This would decrease the worst case to 6 taps instead of 30.
The text was updated successfully, but these errors were encountered: