Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase alarm +/- to 5 min #1101

Closed
1 task done
minacode opened this issue Apr 21, 2022 · 12 comments
Closed
1 task done

Increase alarm +/- to 5 min #1101

minacode opened this issue Apr 21, 2022 · 12 comments

Comments

@minacode
Copy link
Contributor

minacode commented Apr 21, 2022

Verification

  • I searched for similar feature request and found none was relevant.

Pitch us your idea!

Increase the steps for alarm +/- to 5 min.

Description

I guess this is controversial, so sorry for that 😁

Almost always I am not interesetd in setting a alarm to an odd time (say 10:38), but a lot of the time, I end up tapping the +-button a million times to get to the desired time.

I therefore propose to set the alarm time setting steps to 5 min.
Also, we should then make sure to have an initial time that is divisible by 5, to not end up with something like (3, 8, 13, …).

This would decrease the worst case to 6 taps instead of 30.

@SteveAmor
Copy link
Contributor

SteveAmor commented Apr 22, 2022

We could do +5 min and -1 min. To help speed things up? Also +5 secs and -1 secs.

@minacode
Copy link
Contributor Author

Maybe, but this increases the worst case to 12 (or 16 with 1-min steps). Also, I fear it may be too unintuitive for a normal user when + and - behave differently. We would at least have to make this very clear in the UI.

@SteveAmor
Copy link
Contributor

Plenty of room on the buttons to have the text +5 and -1 😀

@minacode
Copy link
Contributor Author

Honestly, I am not convinced of asymmetric +/-. I would go either +1/-1 or +5/-5.

@aiomaster
Copy link

Would it be possible to detect long pressing +/- and to constantly add or decrease the number of minutes?
After 2s holding the step size could increase to 5. So you could fast forward to the time you like and adjust smaller steps by short tapping.

@watertrainer
Copy link

There was some discussion regarding number-selection in #1093. Other ideas were to have a long press on the buttons for higher increase/decrease or double tap ability (although that would be a bit hard to implement).

@minacode
Copy link
Contributor Author

I like the toggle long press idea.

Long press could toggle the buttons into a different mode (with something like red background. Super buttons!) that make +/-5 or maybe even +/-10. Another long press would toggle them back to standard gray +/-1.

@hlessil
Copy link

hlessil commented Apr 24, 2022

Just a long-term thought: Upgrading to LVGL 8 would allow replacing the +/- buttons with a roller widget: https://docs.lvgl.io/8/widgets/core/roller.html

LVGL 7 that InfiniTime is currently using has the roller widget too, but it doesn't support styling. The upgrade from 7 to 8 would not be trivial, but I think it'd pay off: #616

@minacode
Copy link
Contributor Author

That would be the best option 😊 But it seems quite far away right now.

@kieranc
Copy link
Contributor

kieranc commented Apr 28, 2022

Press and hold to quickly increase the time is easy to implement, I've got a UI overhaul for the timer/alarm in the works which does exactly this.

@minacode
Copy link
Contributor Author

I like your work and will close this issue once your changes are merged, because I guess they resolve my initial problem.

@kieranc
Copy link
Contributor

kieranc commented Apr 30, 2022

Ok, I'll publish the PR as soon as I have the stop button fixed, I should be able to link it to this issue so it'll close when merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants