diff --git a/cli/test/helper.go b/cli/test/helper.go index 2d8a907cd9..21bd261df8 100644 --- a/cli/test/helper.go +++ b/cli/test/helper.go @@ -42,8 +42,9 @@ var creds = Credentials{ func ExecuteCliCommand(command string, args ...string) (string, error) { cmd := exec.Command(command, args...) output, err := cmd.CombinedOutput() + if err != nil { - fmt.Println(fmt.Sprint(err) + ": " + string(output)) + fmt.Println(fmt.Sprint(err) + ": " + FilterRequestID(strings.TrimSpace(string(output)))) return FilterRequestID(strings.TrimSpace(string(output))), err } return FilterRequestID(strings.TrimSpace(string(output))), nil @@ -70,11 +71,6 @@ func SetupCli() { } func FilterRequestID(input string) string { - - if !strings.Contains(input, "requestId") && !strings.Contains(input, "reqId") { - return input - } - // Find the JSON part of the error message start := strings.Index(input, "{") end := strings.LastIndex(input, "}") + 1 diff --git a/cli/test/secrets_test.go b/cli/test/secrets_test.go index ba7ce7382c..f7f0f13ffd 100644 --- a/cli/test/secrets_test.go +++ b/cli/test/secrets_test.go @@ -3,7 +3,6 @@ package tests import ( "testing" - "github.com/Infisical/infisical-merge/packages/util" "github.com/bradleyjkemp/cupaloy/v2" ) @@ -96,28 +95,29 @@ func TestUserAuth_SecretsGetAll(t *testing.T) { // testUserAuth_SecretsGetAllWithoutConnection(t) } -func TestUserAuth_SecretsGetAllWithoutConnection(t *testing.T) { - originalConfigFile, err := util.GetConfigFile() - if err != nil { - t.Fatalf("error getting config file") - } - newConfigFile := originalConfigFile - - // set it to a URL that will always be unreachable - newConfigFile.LoggedInUserDomain = "http://localhost:4999" - util.WriteConfigFile(&newConfigFile) - - // restore config file - defer util.WriteConfigFile(&originalConfigFile) - - output, err := ExecuteCliCommand(FORMATTED_CLI_NAME, "secrets", "--projectId", creds.ProjectID, "--env", creds.EnvSlug, "--include-imports=false", "--silent") - if err != nil { - t.Fatalf("error running CLI command: %v", err) - } - - // Use cupaloy to snapshot test the output - err = cupaloy.Snapshot(output) - if err != nil { - t.Fatalf("snapshot failed: %v", err) - } -} +// disabled for the time being +// func testUserAuth_SecretsGetAllWithoutConnection(t *testing.T) { +// originalConfigFile, err := util.GetConfigFile() +// if err != nil { +// t.Fatalf("error getting config file") +// } +// newConfigFile := originalConfigFile + +// // set it to a URL that will always be unreachable +// newConfigFile.LoggedInUserDomain = "http://localhost:4999" +// util.WriteConfigFile(&newConfigFile) + +// // restore config file +// defer util.WriteConfigFile(&originalConfigFile) + +// output, err := ExecuteCliCommand(FORMATTED_CLI_NAME, "secrets", "--projectId", creds.ProjectID, "--env", creds.EnvSlug, "--include-imports=false", "--silent") +// if err != nil { +// t.Fatalf("error running CLI command: %v", err) +// } + +// // Use cupaloy to snapshot test the output +// err = cupaloy.Snapshot(output) +// if err != nil { +// t.Fatalf("snapshot failed: %v", err) +// } +// }