feat: TOTP dynamic secret provider #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheensantoscapadngan
changed the title
scott-ray-wilson
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Only one minor comment on the current code but a couple of thoughts:
-
as a user, if I leased a TOTP dynamic secret I would expect the code to be valid for the duration of the lease; I think it's confusing I can have a valid lease but invalid code - maybe we could disable max/default TTL for TOTP and disable renew/revoke, and configure based of the providers delta and use the
authenticator.timeRemainingto display expiry? -
I had to use a QR code scanner to get the URL - I'm not sure the requested use case for this feature but I think most users would expect to be able to enter the key displayed on 2fa setup pages such as bitbucket or google as an alternative?
frontend/src/views/SecretMainPage/components/DynamicSecretListView/CreateDynamicSecretLease.tsx
Outdated
Show resolved
Hide resolved
scott-ray-wilson
requested changes
Nov 20, 2024
There was a problem hiding this comment.
- I think we should either hide or disable these buttons with a tooltip for TOTP and also probably not showing the expiry since it's provider determined - I know it's a small window but we know this value is incorrect so I think it would be better not to display it?
- I think we should have helper text on the create/update form for TOTP explaining that these default values should work with most providers and should only be configured if the provider explicitly provides different values
- Prereq should include option for key in addition to url
...tend/src/views/SecretMainPage/components/ActionBar/CreateDynamicSecretForm/TotpInputForm.tsx
Outdated
Show resolved
Hide resolved
...ainPage/components/DynamicSecretListView/EditDynamicSecretForm/EditDynamicSecretTotpForm.tsx
Outdated
Show resolved
Hide resolved
scott-ray-wilson
requested changes
Nov 20, 2024
scott-ray-wilson
previously approved these changes
Nov 20, 2024
scott-ray-wilson
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This adds support for new dynamic secret provider - TOTP + documentation
Tested with Bitbucket and our very own TOTP
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets