Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: request ID support #2760

Merged
merged 5 commits into from
Nov 25, 2024
Merged

feat: request ID support #2760

merged 5 commits into from
Nov 25, 2024

Conversation

DanielHougaard
Copy link
Contributor

Description 📣

This PR introduces request ID's on API error responses. This will make it easier to narrow down user-reported erorrs.
Additionally, we've also changed the format of request ID's, to have more entropy. This is done to avoid collisions in our logs.

Minor

  1. I found a bug in the "Create Client Secret" modal, where it would fully crash the application if the user got a ValidationError/zod error from the API. This is also fixed in this PR.
  2. Fixed mismatch between 403/401 errors on the frontend api error handler.
  3. Improved API error handler to be more simplistic.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

@DanielHougaard DanielHougaard self-assigned this Nov 19, 2024
@maidul98 maidul98 requested a review from akhilmhdh November 19, 2024 20:27
sheensantoscapadngan
sheensantoscapadngan reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add reqId to log points

sheensantoscapadngan
sheensantoscapadngan previously approved these changes Nov 25, 2024
View reviewed changes
backend/src/server/app.ts Show resolved Hide resolved
@DanielHougaard DanielHougaard removed the request for review from akhilmhdh November 25, 2024 12:12
@DanielHougaard DanielHougaard merged commit 2f9e542 into main Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheensantoscapadngan sheensantoscapadngan sheensantoscapadngan approved these changes

Assignees

@DanielHougaard DanielHougaard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielHougaard @sheensantoscapadngan