Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jwt auth #2857

Merged
merged 10 commits into from
Dec 13, 2024
Merged

feat: jwt auth #2857

merged 10 commits into from
Dec 13, 2024

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Dec 9, 2024

Description 📣

This PR adds a new identity auth method called JWT.
image

Usage diagram:
image

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@sheensantoscapadngan sheensantoscapadngan marked this pull request as ready for review December 11, 2024 16:49
@sheensantoscapadngan sheensantoscapadngan changed the title WIP feat: jwt auth feat: jwt auth Dec 11, 2024
dangtony98
dangtony98 previously approved these changes Dec 13, 2024
Copy link
Collaborator

@dangtony98 dangtony98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangtony98 dangtony98 dismissed their stale review December 13, 2024 05:57

Need to add support for numbers in JWT payload

Copy link
Collaborator

@dangtony98 dangtony98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sheensantoscapadngan sheensantoscapadngan merged commit 16ea757 into main Dec 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants