Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add live refresh for following apps #94

Closed
zDyanTB opened this issue Jul 22, 2024 · 8 comments
Closed

[Request] Add live refresh for following apps #94

zDyanTB opened this issue Jul 22, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@zDyanTB
Copy link

zDyanTB commented Jul 22, 2024

These apps don't auto reload, and need these commands to read new colors

App: command

bat: bat cache --build
swaync: swayns-client -rs

@InioX InioX added the enhancement New feature or request label Jul 22, 2024
@NotMephisto
Copy link

It would be nice to add rofi and swayosd too

@Davenchy
Copy link
Contributor

Davenchy commented Aug 12, 2024

I suggest adding an option to the TOML config file under the template section, such as exec, or perhaps splitting it into pre_exec and post_exec. This option would allow users to specify a shell command to be executed automatically.

  • The exec option would run the specified command after the template generation is complete.
  • Alternatively, the pre_exec option could run the command before generation, and the post_exec option could run it after generation.

I believe this approach would be more effective than implementing commands for each requested app individually. It would give users the flexibility to restart or perform any necessary actions before or after generating templates according to their needs.


I recall something similar might have been added before, possibly called hook, but it’s not mentioned in the documentation, so I’m unsure if it’s the same feature or something different.
I am talking about #83 (comment)


Anyway, Here’s an example using the exec approach:

[templates.swaync]
input_path = '~/.config/swaync/style-template.css'
output_path = '~/.config/swaync/style.css'
exec = 'swaync-client --reload-config && swaync-client --reload-css'

And here’s an example using the {pre/post}_exec approach:

[templates.some_app]
input_path = '~/.config/some_app/template.ext'
output_path = '~/.config/some_app/generated.ext'
pre_exec = 'echo "before generating" >> ~/logs'
post_exec = 'echo "after generating" >> ~/logs'

@InioX
Copy link
Owner

InioX commented Aug 13, 2024

I've also been thinking of automatically reloading when the template has a specific name like sway or something else. Every template would have an option to enable/disable the auto reload.

@Davenchy
Copy link
Contributor

I've also been thinking of automatically reloading when the template has a specific name like sway or something else. Every template would have an option to enable/disable the auto reload.

This would be a great feature. However, my suggestion to implement after/before generation hooks is to allow users to write custom scripts tailored to their own environments. From my perspective, adding specific code for auto-reloading based on template names like sway could lead to more complex code, additional requests to support other tools, and potential future bugs and code maintenance issues.

@InioX
Copy link
Owner

InioX commented Aug 15, 2024

I already added the pre_hook and post_hook stuff in #100.

@DaniD3v
Copy link
Collaborator

DaniD3v commented Aug 18, 2024

honestly I don't think this is a good idea.
We should just make a directory of example hooks so that users can simply copy/paste.

@Davenchy
Copy link
Contributor

honestly I don't think this is a good idea. We should just make a directory of example hooks so that users can simply copy/paste.

I didn't get your idea. Could you make it clear?
Like, What do you mean by saying hooks and example hooks?

@DaniD3v
Copy link
Collaborator

DaniD3v commented Aug 19, 2024

Take a look at #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants