Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version check optional #78

Closed
Theaninova opened this issue Jun 10, 2024 · 2 comments
Closed

Make version check optional #78

Theaninova opened this issue Jun 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Theaninova
Copy link
Contributor

Theaninova commented Jun 10, 2024

The version check seems to take a rather substantial amount of the execution time, as well as being useless if the app is installed via the system package manager.

Imo the check should be opt-in, as it makes a network request that is not required for the app to function.

@InioX InioX added the enhancement New feature or request label Jun 10, 2024
@InioX
Copy link
Owner

InioX commented Jun 10, 2024

Would adding a config option for it that's disabled by default be fine?

@Theaninova
Copy link
Contributor Author

I think a config option would be the best option, I'm not sure if you meant disabled by default as in turning off the check is off by default or turning on the check is disabled by default, I think either is fine though I'd advocate for the check being opt-in (so off by default) rather than opt out, or a build flag for the default state so it can be turned off when packaging for non-cargo targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants