STYLE: Mimic code that was reviewed for the upstream HDF5 source

InsightSoftwareConsortium · Mar 30, 2021 · 090399d · 090399d
1 parent 4f64c6c
commit 090399d
Showing 1 changed file with 4 additions and 10 deletions.
diff --git a/Modules/ThirdParty/HDF5/src/itkhdf5/c++/src/H5DataSet.cpp b/Modules/ThirdParty/HDF5/src/itkhdf5/c++/src/H5DataSet.cpp
@@ -87,16 +87,10 @@ DataSet::DataSet(const DataSet& original) : H5Object(), AbstractDs(), id(origina
 DataSet &
 DataSet::operator=(const DataSet &original)
 {
-    // Wrap the changes to `*this` by an incremented reference count for
-    // `original` to prevent trouble in the case that `*this` and
-    // `original` share reference counts or memory in any relevant
-    // sense.
-    original.incRefCount();
-    decRefCount(); // for old value of id
-    id = original.id;
-    incRefCount(); // for new value of id
-    original.decRefCount();
-    return *this;
+    if (this != &original) {
+        setId(original.id);
+    }
+    return (*this);
 }
 
 //--------------------------------------------------------------------------