STYLE: Replace "itk::ERROR" by "ITK ERROR" in description of exception

Previously, the description text of an exception thrown by `itkSpecializedMessageExceptionMacro` would start with the text "itk::ERROR", which seemed to suggest that it involved an `itk::ERROR` object, function, or type. However, there is no such `ERROR` in the `itk` namespace! It appears clearer to use the text "ITK ERROR" instead, to indicate that the error involves the ITK library.
InsightSoftwareConsortium · Mar 12, 2021 · 2b34388 · 2b34388
1 parent e6d5e09
commit 2b34388
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Modules/Core/Common/include/itkMacro.h b/Modules/Core/Common/include/itkMacro.h
@@ -511,7 +511,7 @@ OutputWindowDisplayDebugText(const char *);
 #define itkSpecializedMessageExceptionMacro(ExceptionType, x)                                                          \
   {                                                                                                                    \
     std::ostringstream message;                                                                                        \
-    message << "itk::ERROR: " x;                                                                                       \
+    message << "ITK ERROR: " x;                                                                                        \
     throw ::itk::ExceptionType(                                                                                        \
       std::string{ __FILE__ }, __LINE__, std::string{ message.str() }, std::string{ ITK_LOCATION });                   \
   }                                                                                                                    \

diff --git a/Modules/Core/Common/test/itkExceptionObjectGTest.cxx b/Modules/Core/Common/test/itkExceptionObjectGTest.cxx
@@ -60,7 +60,7 @@ TEST(ExceptionObject, TestDescriptionFromExceptionMacro)
     ASSERT_NE(actualDescription, nullptr);
 
     std::ostringstream expectedDescription;
-    expectedDescription << "itk::ERROR: " << testObject.GetNameOfClass() << "(" << &testObject << "): " << testMessage;
+    expectedDescription << "ITK ERROR: " << testObject.GetNameOfClass() << "(" << &testObject << "): " << testMessage;
 
     EXPECT_EQ(actualDescription, expectedDescription.str());
   }
@@ -78,7 +78,7 @@ TEST(ExceptionObject, TestDescriptionFromSpecializedExceptionMacro)
   {
     const char * const description = exceptionObject.GetDescription();
     ASSERT_NE(description, nullptr);
-    EXPECT_EQ(description, std::string("itk::ERROR: ") + itk::GTest_SpecializedException::default_exception_message);
+    EXPECT_EQ(description, std::string("ITK ERROR: ") + itk::GTest_SpecializedException::default_exception_message);
   }
 }