ENH: Use InPlaceImageFilter for base class, run in-place by default

Enable not copying the input image's bulk pixel data by default.
InsightSoftwareConsortium · Sep 10, 2021 · 4379b75 · 4379b75
1 parent 374940a
commit 4379b75
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/Modules/Core/Transform/include/itkTransformGeometryImageFilter.h b/Modules/Core/Transform/include/itkTransformGeometryImageFilter.h
@@ -19,7 +19,7 @@
 #ifndef itkTransformGeometryImageFilter_h
 #define itkTransformGeometryImageFilter_h
 
-#include "itkImageToImageFilter.h"
+#include "itkInPlaceImageFilter.h"
 #include "itkVersorRigid3DTransform.h"
 #include "itkDataObjectDecorator.h"
 
@@ -100,22 +100,22 @@ namespace itk
  * \ingroup ITKTransform
  */
 template <typename TInputImage, typename TOutputImage>
-class ITK_TEMPLATE_EXPORT TransformGeometryImageFilter : public ImageToImageFilter<TInputImage, TOutputImage>
+class ITK_TEMPLATE_EXPORT TransformGeometryImageFilter : public InPlaceImageFilter<TInputImage, TOutputImage>
 {
 public:
   ITK_DISALLOW_COPY_AND_MOVE(TransformGeometryImageFilter);
 
   /** Standard class type alias */
   using Self = TransformGeometryImageFilter;
-  using Superclass = ImageToImageFilter<TInputImage, TOutputImage>;
+  using Superclass = InPlaceImageFilter<TInputImage, TOutputImage>;
   using Pointer = SmartPointer<Self>;
   using ConstPointer = SmartPointer<const Self>;
 
   /** Method for creation through the object factory */
   itkNewMacro(Self);
 
   /** Run-time type information (and related methods) */
-  itkTypeMacro(TransformGeometryImageFilter, ImageToImageFilter);
+  itkTypeMacro(TransformGeometryImageFilter, InPlaceImageFilter);
 
   /** input/output image type alias */
   using InputImageType = TInputImage;

diff --git a/Modules/Core/Transform/include/itkTransformGeometryImageFilter.hxx b/Modules/Core/Transform/include/itkTransformGeometryImageFilter.hxx
@@ -69,6 +69,11 @@ template <typename TInputImage, typename TOutputImage>
 void
 TransformGeometryImageFilter<TInputImage, TOutputImage>::GenerateData()
 {
+  if (this->GetRunningInPlace())
+  {
+    // No need to copy the bulk data
+    return;
+  }
   OutputImageType * output = this->GetOutput();
 
   auto input = InputImageType::New();
@@ -87,6 +92,7 @@ TransformGeometryImageFilter<TInputImage, TOutputImage>::GenerateData()
 
   // Can't use graft as it will overwrite the new meta-data
   output->SetPixelContainer(castFilter->GetOutput()->GetPixelContainer());
+  output->SetBufferedRegion(castFilter->GetOutput()->GetBufferedRegion());
 }
 
 } // end namespace itk

diff --git a/Modules/Core/Transform/test/itkTransformGeometryImageFilterTest.cxx b/Modules/Core/Transform/test/itkTransformGeometryImageFilterTest.cxx
@@ -127,7 +127,7 @@ itkTransformGeometryImageFilterTest(int argc, char * argv[])
 
   // Set up the transform filter
   FilterType::Pointer filter = FilterType::New();
-  ITK_EXERCISE_BASIC_OBJECT_METHODS(filter, TransformGeometryImageFilter, ImageToImageFilter);
+  ITK_EXERCISE_BASIC_OBJECT_METHODS(filter, TransformGeometryImageFilter, InPlaceImageFilter);
 
   // Test the exceptions
   ITK_TRY_EXPECT_EXCEPTION(filter->Update());