Skip to content

Commit

Permalink
STYLE: Method local variables should not have m_ prefix
Browse files Browse the repository at this point in the history
  • Loading branch information
Leengit authored and dzenanz committed Sep 23, 2022
1 parent 090cb23 commit 4b5842f
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions Modules/Core/Common/src/itkObjectFactoryBase.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ class ObjectFactoryBasePrivate : public LightObject
~ObjectFactoryBasePrivate() override
{
itk::ObjectFactoryBase::UnRegisterAllFactories();
for (auto & m_InternalFactorie : m_InternalFactories)
for (auto & internalFactory : m_InternalFactories)
{
m_InternalFactorie->UnRegister();
internalFactory->UnRegister();
}
}

Expand Down
4 changes: 2 additions & 2 deletions Modules/Core/Mesh/include/itkConnectedRegionsMeshFilter.hxx
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,9 @@ ConnectedRegionsMeshFilter<TInputMesh, TOutputMesh>::GenerateData()
if (this->GetDebug())
{
SizeValueType count = 0;
for (const auto & m_RegionSize : m_RegionSizes)
for (const auto & regionSize : m_RegionSizes)
{
count += m_RegionSize;
count += regionSize;
}
itkDebugMacro(<< "Total #of cells accounted for: " << count);
itkDebugMacro(<< "Extracted " << output->GetNumberOfCells() << " cells");
Expand Down
20 changes: 10 additions & 10 deletions Modules/IO/GDCM/src/itkGDCMSeriesFileNames.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -209,40 +209,40 @@ GDCMSeriesFileNames::GetOutputFileNames()
if (!m_InputFileNames.empty())
{
bool hasExtension = false;
for (const auto & m_InputFileName : m_InputFileNames)
for (const auto & inputFileName : m_InputFileNames)
{
// look for extension ".dcm" and ".DCM"
std::string::size_type dcmPos = m_InputFileName.rfind(".dcm");
if ((dcmPos != std::string::npos) && (dcmPos == m_InputFileName.length() - 4))
std::string::size_type dcmPos = inputFileName.rfind(".dcm");
if ((dcmPos != std::string::npos) && (dcmPos == inputFileName.length() - 4))
{
hasExtension = true;
}
else
{
dcmPos = m_InputFileName.rfind(".DCM");
if ((dcmPos != std::string::npos) && (dcmPos == m_InputFileName.length() - 4))
dcmPos = inputFileName.rfind(".DCM");
if ((dcmPos != std::string::npos) && (dcmPos == inputFileName.length() - 4))
{
hasExtension = true;
}
}

// look for extension ".dicom" and ".DICOM"
std::string::size_type dicomPos = m_InputFileName.rfind(".dicom");
if ((dicomPos != std::string::npos) && (dicomPos == m_InputFileName.length() - 6))
std::string::size_type dicomPos = inputFileName.rfind(".dicom");
if ((dicomPos != std::string::npos) && (dicomPos == inputFileName.length() - 6))
{
hasExtension = true;
}
else
{
dicomPos = m_InputFileName.rfind(".DICOM");
if ((dicomPos != std::string::npos) && (dicomPos == m_InputFileName.length() - 6))
dicomPos = inputFileName.rfind(".DICOM");
if ((dicomPos != std::string::npos) && (dicomPos == inputFileName.length() - 6))
{
hasExtension = true;
}
}

// construct a filename, adding an extension if necessary
std::string filename = m_OutputDirectory + itksys::SystemTools::GetFilenameName(m_InputFileName);
std::string filename = m_OutputDirectory + itksys::SystemTools::GetFilenameName(inputFileName);
if (!hasExtension)
{
// input filename has no extension, add a ".dcm"
Expand Down

0 comments on commit 4b5842f

Please sign in to comment.