Skip to content

Commit

Permalink
ENH: Increase hook-max-size for next GDCM update
Browse files Browse the repository at this point in the history
Also, fix existing typos: `hook-max-size` to `hooks-max-size`.
The singular has no effect.

For the after-merge commit ghostflow errors (second and third),
we modify the top `.gitattributes`
For the import commit ghostflow error (first), we modify `.gitattributes` from
the UpdateFromUpstream `extract_source`.

See the conversation associated to this PR for more details.

```
commit b creates blob x at Source/DataDictionary/gdcmDefaultDicts.cxx with size 1194766 bytes (1166.76 KiB) which is greater than the maximum size 1048576 bytes (1024.00 KiB). If the file is intended to be committed, set the hooks-max-size attribute on its path.
commit a creates blob x at Modules/ThirdParty/GDCM/src/gdcm/Source/DataDictionary/gdcmDefaultDicts.cxx with size 1194766 bytes (1166.76 KiB) which is greater than the maximum size 300000 bytes (292.97 KiB). If the file is intended to be committed, set the hooks-max-size attribute on its path.
commit a creates blob x at Modules/ThirdParty/GDCM/src/gdcm/Source/DataDictionary/gdcmDefaultDicts.cxx with size 1194766 bytes (1166.76 KiB) which is greater than the maximum size 300000 bytes (292.97 KiB). If the file is intended to be committed, set the hooks-max-size attribute on its path.
Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.
```
  • Loading branch information
phcerdan authored and thewtex committed Aug 11, 2021
1 parent 278ac68 commit f913c0b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
18 changes: 10 additions & 8 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,15 @@ Modules/Filtering/Denoising/include/itkPatchBasedDenoisingImageFilter.hxx hooks-
Documentation/ReleaseNotes/* hooks-max-size=300000
Utilities/Doxygen/doxygen.config.in hooks-max-size=150000

Modules/ThirdParty/GDCM/src/gdcm/Source/DataDictionary/gdcmPrivateDefaultDicts.cxx hook-max-size=1021501
Modules/ThirdParty/GDCM/src/gdcm/Utilities/gdcmopenjpeg/src/lib/openjp2/j2k.c hook-max-size=654063
Modules/ThirdParty/GDCM/src/gdcm/Source/InformationObjectDefinition/Part3.xml hook-max-size=4336000
Source/InformationObjectDefinition/Part3.xml hook-max-size=4336000
Modules/ThirdParty/GDCM/src/gdcm/Source/DataDictionary/gdcmPrivateDefaultDicts.cxx hooks-max-size=1021501
Modules/ThirdParty/GDCM/src/gdcm/Source/DataDictionary/gdcmDefaultDicts.cxx hooks-max-size=1200000
Source/DataDictionary/gdcmDefaultDicts.cxx hooks-max-size=1200000
Modules/ThirdParty/GDCM/src/gdcm/Utilities/gdcmopenjpeg/src/lib/openjp2/j2k.c hooks-max-size=654063
Modules/ThirdParty/GDCM/src/gdcm/Source/InformationObjectDefinition/Part3.xml hooks-max-size=4336000
Source/InformationObjectDefinition/Part3.xml hooks-max-size=4336000

# Avoid ghostflow-check-master failures
Modules/ThirdParty/HDF5/src/itkhdf5/src/H5C.c hook-max-size=400000
Modules/ThirdParty/HDF5/src/itkhdf5/src/H5Dchunk.c hook-max-size=400000
Modules/ThirdParty/HDF5/src/itkhdf5/src/H5Shyper.c hook-max-size=500000
Modules/ThirdParty/HDF5/src/itkhdf5/src/H5Tconv.c hook-max-size=500000
Modules/ThirdParty/HDF5/src/itkhdf5/src/H5C.c hooks-max-size=400000
Modules/ThirdParty/HDF5/src/itkhdf5/src/H5Dchunk.c hooks-max-size=400000
Modules/ThirdParty/HDF5/src/itkhdf5/src/H5Shyper.c hooks-max-size=500000
Modules/ThirdParty/HDF5/src/itkhdf5/src/H5Tconv.c hooks-max-size=500000
1 change: 1 addition & 0 deletions Modules/ThirdParty/GDCM/UpdateFromUpstream.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ extract_source () {
git_archive
pushd "${extractdir}/${name}-reduced"
echo "* -whitespace" > .gitattributes
echo "Source/DataDictionary/gdcmDefaultDicts.cxx hooks-max-size=1200000" >> .gitattributes
popd
}

Expand Down

0 comments on commit f913c0b

Please sign in to comment.