-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itkStatisticsUniqueLabelMapFilterTest1 test fails under TSan (Thread Sanitizer) #3031
Comments
That may be the long standing issue with that test/filter! Nice find! |
There's a long-standing issue? Is there another ticket to relate this one to? |
It might have gotten resolved at some point, or the test stopped failing "randomly. There was an issue.... I'm unsure of the state to be honest. But there is mention of it in the code:
a18b3cf#diff-ce29fb0f5bbe68109294658b036c1a46f17abed19ce9168df44958670be4bf09 From back in the JIRA days 😃 |
Most recent nightly failure: https://open.cdash.org/test/552477773. I think there was a continuous build failure just a few days ago (I am too lazy to search for it). |
Great @seanm !
The test has been failing on and off, e.g. latest failure on the |
I've gone through all the TSan failures, and the following all basically have the same bug:
|
Two different threads (
T16
thenT10
) decide to write to the same pixel. Perhaps they are writing the same colour, but that's still undefined behaviour.Perhaps the bug is that they should be writing to different pixels? Otherwise, it seems that some mutex or other synchronization would need to be added.
Full TSan output is:
The text was updated successfully, but these errors were encountered: