Added metrics and tests

Instagram · Jul 30, 2024 · 06c0a92 · 06c0a92
1 parent 3126ee8
commit 06c0a92
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/fixit/engine.py b/src/fixit/engine.py
@@ -114,6 +114,9 @@ def visit_hook(name: str) -> Iterator[None]:
                     violation = replace(violation, diff=diff)
 
                 yield violation
+
+        self.metrics["ViolationCount.Total"] = count
+
         if metrics_hook:
             metrics_hook(self.metrics)
 

diff --git a/src/fixit/tests/rule.py b/src/fixit/tests/rule.py
@@ -47,9 +47,12 @@ def test_timing(self) -> None:
         rule = NoopRule()
         for _ in self.runner.collect_violations([rule], Config()):
             pass  # exhaust the generator
-        self.assertIn("NoopRule.visit_Module", self.runner.metrics)
-        self.assertIn("NoopRule.leave_Module", self.runner.metrics)
+        self.assertIn("Duration.NoopRule.visit_Module", self.runner.metrics)
+        self.assertIn("Duration.NoopRule.leave_Module", self.runner.metrics)
         self.assertGreaterEqual(self.runner.metrics["NoopRule.visit_Module"], 0)
+        self.assertIn("ViolationCount.Noop", self.runner.metrics)
+        self.assertIn("ViolationCountWithReplacement.Noop", self.runner.metrics)
+        self.assertIn("ViolationCount.Total", self.runner.metrics)
 
     def test_timing_hook(self) -> None:
         rule = NoopRule()