Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: implement LSP #387

Closed
1 of 2 tasks
llllvvuu opened this issue Sep 6, 2023 · 0 comments · Fixed by #390
Closed
1 of 2 tasks

feature: implement LSP #387

llllvvuu opened this issue Sep 6, 2023 · 0 comments · Fixed by #390
Labels
enhancement New feature or request

Comments

@llllvvuu
Copy link
Contributor

llllvvuu commented Sep 6, 2023 •
edited
Loading

A bit of a long shot, but ruff implements it. As do ESLint and Biome f.k.a. Rome for JavaScript.

Benefit of a language server:

  • perf: persistent process throughout an editing session
  • code actions: treat single issues (ignore for this line, ignore for this file, fix this line)

LSP docs
pygls docs

Potentially lower-hanging fruits:

Related: #122 - many VSCode extensions are built using LSP. Just wanted to flag the protocol since there is a failure mode of building a VSCode extension without the protocol and thus not supporting other editors.

Workaround: let third-parties build daemons/LSPs off of the Fixit API
This was referenced Sep 6, 2023
Merged
Open
@llllvvuu llllvvuu changed the title feature: LSP feature: implement LSP Sep 6, 2023
llllvvuu added a commit to llllvvuu/Fixit that referenced this issue Sep 7, 2023
@llllvvuu
feat(lsp): live diagnostics, fix whole file
70ad9f7 
resolves Instagram#387

Also adds --log-file CLI arg so that the language server can be
observable.

In the interest of keeping the PR small, the following are not included
in this PR:

* Debouncing
* Code Actions
* Vendor [Generic LSP Client](https://github.com/llllvvuu/vscode-glspc)
  to add Fixit branding (code works out of the box, only `README.md`,
  `LICENSE`, and `package.json` would need to be changed. I published
  MIT license so it's free to use.)
@llllvvuu llllvvuu mentioned this issue Sep 7, 2023
Merged
5 tasks
llllvvuu added a commit to llllvvuu/Fixit that referenced this issue Sep 7, 2023
@llllvvuu
feat(lsp): live diagnostics, fix whole file
d4b6989 
resolves Instagram#387 Instagram#122

Also adds --log-file CLI arg so that the language server can be
observable.

In the interest of keeping the PR small, the following are not included
in this PR:

* Debouncing
* Code Actions
* Vendor [Generic LSP Client](https://github.com/llllvvuu/vscode-glspc)
  to add Fixit branding (code works out of the box, only `README.md`,
  `LICENSE`, and `package.json` would need to be changed. I published
  MIT license so it's free to use.)
@amyreese amyreese added the enhancement New feature or request label Sep 7, 2023
llllvvuu added a commit to llllvvuu/Fixit that referenced this issue Sep 7, 2023
@llllvvuu
feat(lsp): live diagnostics, fix whole file
def9707 
resolves Instagram#387 Instagram#122

Support for:
- [x] `textDocument/didOpen`, `textDocument/didChange` -> `textDocument/publishDiagnostics`
- [x] `textDocument/formatting`

Also adds --log-file CLI arg so that the language server can be observable.

In the interest of keeping the PR small, the following are not included in this PR:

- [ ] `textDocument/codeAction`, `workspace/executeCommand`
- [ ] Debouncing
- [ ] Vendor [Generic LSP Client](https://github.com/llllvvuu/vscode-glspc) to add Fixit branding (code works out of the box, only `README.md`, `LICENSE`, and `package.json` would need to be changed. I published MIT license so it's free to use.)

If this PR gets merged I will create follow-up issues for these items.

test: Added new smoke test for the new `fixit lsp` subcommand.
llllvvuu added a commit to llllvvuu/Fixit that referenced this issue Sep 8, 2023
@llllvvuu
feat(lsp): live diagnostics, fix whole file
3ff2f93 
resolves Instagram#387 Instagram#122

Support for:
- [x] `textDocument/didOpen`, `textDocument/didChange` -> `textDocument/publishDiagnostics`
- [x] `textDocument/formatting`

Also adds --log-file CLI arg so that the language server can be observable.

In the interest of keeping the PR small, the following are not included in this PR:

- [ ] `textDocument/codeAction`, `workspace/executeCommand`
- [ ] Debouncing
- [ ] Vendor [Generic LSP Client](https://github.com/llllvvuu/vscode-glspc) to add Fixit branding (code works out of the box, only `README.md`, `LICENSE`, and `package.json` would need to be changed. I published MIT license so it's free to use.)

If this PR gets merged I will create follow-up issues for these items.

test: Added new smoke test for the new `fixit lsp` subcommand.
llllvvuu added a commit to llllvvuu/Fixit that referenced this issue Sep 9, 2023
@llllvvuu
feat: add fixit lsp subcommand
b37baca 
resolves Instagram#387 Instagram#122

Support for:
- [x] `textDocument/didOpen`, `textDocument/didChange` -> `textDocument/publishDiagnostics`
- [x] `textDocument/formatting`

Also adds --log-file CLI arg so that the language server can be observable.

In the interest of keeping the PR small, the following are not included in this PR:

- [ ] `textDocument/codeAction`, `workspace/executeCommand`
- [ ] `workspace/didChangeWatchedFiles` to invalidate the config cache
- [ ] Vendor [Generic LSP Client](https://github.com/llllvvuu/vscode-glspc) to add Fixit branding (code works out of the box, only `README.md`, `LICENSE`, and `package.json` would need to be changed. I published MIT license so it's free to use.)

If this PR gets merged I will create follow-up issues for these items.

test: Added new smoke test for the new `fixit lsp` subcommand.
llllvvuu added a commit to llllvvuu/Fixit that referenced this issue Sep 10, 2023
@llllvvuu
feat: add fixit lsp subcommand
d7e6512 
resolves Instagram#387 Instagram#122

Support for:
- [x] `textDocument/didOpen`, `textDocument/didChange` -> `textDocument/publishDiagnostics`
- [x] `textDocument/formatting`

Also adds --log-file CLI arg so that the language server can be observable.

In the interest of keeping the PR small, the following are not included in this PR:

- [ ] `textDocument/codeAction`, `workspace/executeCommand`
- [ ] `workspace/didChangeWatchedFiles` to invalidate the config cache
- [ ] Vendor [Generic LSP Client](https://github.com/llllvvuu/vscode-glspc) to add Fixit branding (code works out of the box, only `README.md`, `LICENSE`, and `package.json` would need to be changed. I published MIT license so it's free to use.)

If this PR gets merged I will create follow-up issues for these items.

test: Added new smoke test for the new `fixit lsp` subcommand.
llllvvuu added a commit to llllvvuu/Fixit that referenced this issue Sep 10, 2023
@llllvvuu
feat: add fixit lsp subcommand
fab183e 
resolves Instagram#387 Instagram#122

Support for:
- [x] `textDocument/didOpen`, `textDocument/didChange` -> `textDocument/publishDiagnostics`
- [x] `textDocument/formatting`

Also adds --log-file CLI arg so that the language server can be observable.

In the interest of keeping the PR small, the following are not included in this PR:

- [ ] `textDocument/codeAction`, `workspace/executeCommand`
- [ ] `workspace/didChangeWatchedFiles` to invalidate the config cache
- [ ] Vendor [Generic LSP Client](https://github.com/llllvvuu/vscode-glspc) to add Fixit branding (code works out of the box, only `README.md`, `LICENSE`, and `package.json` would need to be changed. I published MIT license so it's free to use.)

If this PR gets merged I will create follow-up issues for these items.

test: Added new smoke test for the new `fixit lsp` subcommand.
llllvvuu added a commit to llllvvuu/Fixit that referenced this issue Sep 10, 2023
@llllvvuu
feat: add fixit lsp subcommand
2551e15 
resolves Instagram#387 Instagram#122

Support for:
- [x] `textDocument/didOpen`, `textDocument/didChange` -> `textDocument/publishDiagnostics`
- [x] `textDocument/formatting`

Also adds --log-file CLI arg so that the language server can be observable.

In the interest of keeping the PR small, the following are not included in this PR:

- [ ] `textDocument/codeAction`, `workspace/executeCommand`
- [ ] `workspace/didChangeWatchedFiles` to invalidate the config cache
- [ ] Vendor [Generic LSP Client](https://github.com/llllvvuu/vscode-glspc) to add Fixit branding (code works out of the box, only `README.md`, `LICENSE`, and `package.json` would need to be changed. I published MIT license so it's free to use.)

If this PR gets merged I will create follow-up issues for these items.

test: Added new smoke test for the new `fixit lsp` subcommand.
llllvvuu added a commit to llllvvuu/Fixit that referenced this issue Sep 10, 2023
@llllvvuu
feat: add fixit lsp subcommand
1d748d8 
resolves Instagram#387 Instagram#122

Support for:
- [x] `textDocument/didOpen`, `textDocument/didChange` -> `textDocument/publishDiagnostics`
- [x] `textDocument/formatting`

Also adds --log-file CLI arg so that the language server can be observable.

In the interest of keeping the PR small, the following are not included in this PR:

- [ ] `textDocument/codeAction`, `workspace/executeCommand`
- [ ] `workspace/didChangeWatchedFiles` to invalidate the config cache
- [ ] Vendor [Generic LSP Client](https://github.com/llllvvuu/vscode-glspc) to add Fixit branding (code works out of the box, only `README.md`, `LICENSE`, and `package.json` would need to be changed. I published MIT license so it's free to use.)

If this PR gets merged I will create follow-up issues for these items.

test: Added new smoke test for the new `fixit lsp` subcommand.
llllvvuu added a commit to llllvvuu/Fixit that referenced this issue Sep 27, 2023
@llllvvuu
feat: add fixit lsp subcommand
d2ec9d6 
resolves Instagram#387 Instagram#122

Support for:
- [x] `textDocument/didOpen`, `textDocument/didChange` -> `textDocument/publishDiagnostics`
- [x] `textDocument/formatting`

Also adds --log-file CLI arg so that the language server can be observable.

In the interest of keeping the PR small, the following are not included in this PR:

- [ ] `textDocument/codeAction`, `workspace/executeCommand`
- [ ] `workspace/didChangeWatchedFiles` to invalidate the config cache
- [ ] Vendor [Generic LSP Client](https://github.com/llllvvuu/vscode-glspc) to add Fixit branding (code works out of the box, only `README.md`, `LICENSE`, and `package.json` would need to be changed. I published MIT license so it's free to use.)

If this PR gets merged I will create follow-up issues for these items.

test: Added new smoke test for the new `fixit lsp` subcommand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add fixit lsp subcommand llllvvuu/Fixit
2 participants
@amyreese @llllvvuu