Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust typing literal handling #400

Merged
merged 1 commit into from
Oct 24, 2023
Merged

More robust typing literal handling #400

merged 1 commit into from
Oct 24, 2023

Conversation

amyreese
Copy link
Member

@amyreese amyreese commented Oct 24, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

Includes typing.Literal in the checks, adds a test case, and
wraps the call to parse_expression in a try/except just in case.

Fix #377

@amyreese
More robust typing literal handling
4da09f1 
Includes `typing.Literal` in the checks, adds a test case, and
wraps the call to `parse_expression` in a try/except just in case.

Fix #377

[ghstack-poisoned]
@amyreese amyreese requested a review from zsol as a code owner October 24, 2023 19:25
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2023
amyreese added a commit that referenced this pull request Oct 24, 2023
@amyreese
More robust typing literal handling
21360fe 
Includes `typing.Literal` in the checks, adds a test case, and
wraps the call to `parse_expression` in a try/except just in case.

Fix #377

ghstack-source-id: 01775325c8aa7907568531ff47e60862e02d2915
Pull Request resolved: #400
@amyreese amyreese mentioned this pull request Oct 24, 2023
Merged
@amyreese amyreese merged commit 4da09f1 into gh/amyreese/1/base Oct 24, 2023
13 checks passed
amyreese added a commit that referenced this pull request Oct 24, 2023
@amyreese
More robust typing literal handling
fc2117b 
Includes `typing.Literal` in the checks, adds a test case, and
wraps the call to `parse_expression` in a try/except just in case.

Fix #377

ghstack-source-id: 01775325c8aa7907568531ff47e60862e02d2915
Pull Request resolved: #400
@amyreese amyreese deleted the gh/amyreese/1/head branch October 24, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsol zsol Awaiting requested review from zsol zsol is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amyreese @facebook-github-bot