Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a targeted (named rule) enable to override a module disable #463

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

amyreese
Copy link
Member

@amyreese amyreese commented Jun 21, 2024

Stack from ghstack (oldest at bottom):

This allows the following configuration to work as a way of disabling
all of the builtin rules except for specific ones:

[tool.fixit]
disable = ["fixit.rules"]
enable = ["fixit.rules:UseClsInClassmethod"]

Co-authored-by: surge119 ly.sergio480@gmail.com

[ghstack-poisoned]
@amyreese amyreese requested a review from zsol as a code owner June 21, 2024 00:51
amyreese added a commit that referenced this pull request Jun 21, 2024
This allows the following configuration to work as a way of disabling
all of the builtin rules except for specific ones:

```
[tool.fixit]
disable = ["fixit.rules"]
enable = ["fixit.rules:UseClsInClassmethod"]
```

ghstack-source-id: 51fad59fc8536a5447abe88ececa40e27a49ef96
Pull Request resolved: #463
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 21, 2024
amyreese added a commit that referenced this pull request Jun 21, 2024
This allows the following configuration to work as a way of disabling
all of the builtin rules except for specific ones:

```
[tool.fixit]
disable = ["fixit.rules"]
enable = ["fixit.rules:UseClsInClassmethod"]
```

Co-authored-by: surge119 <ly.sergio480@gmail.com>

ghstack-source-id: 51fad59fc8536a5447abe88ececa40e27a49ef96
Pull Request resolved: #463
amyreese added a commit that referenced this pull request Jun 21, 2024
This allows the following configuration to work as a way of disabling
all of the builtin rules except for specific ones:

```
[tool.fixit]
disable = ["fixit.rules"]
enable = ["fixit.rules:UseClsInClassmethod"]
```

Co-authored-by: surge119 <ly.sergio480@gmail.com>

ghstack-source-id: 51fad59fc8536a5447abe88ececa40e27a49ef96
Pull Request resolved: #463
amyreese added a commit that referenced this pull request Jun 21, 2024
This allows the following configuration to work as a way of disabling
all of the builtin rules except for specific ones:

```
[tool.fixit]
disable = ["fixit.rules"]
enable = ["fixit.rules:UseClsInClassmethod"]
```

Co-authored-by: surge119 <ly.sergio480@gmail.com>

ghstack-source-id: 51fad59fc8536a5447abe88ececa40e27a49ef96
Pull Request resolved: #463
@amyreese amyreese requested a review from surge119 June 21, 2024 01:11
@surge119 surge119 merged commit f0dfb39 into gh/amyreese/3/base Jun 21, 2024
16 checks passed
amyreese added a commit that referenced this pull request Jun 21, 2024
@amyreese amyreese deleted the gh/amyreese/3/head branch June 21, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants